[TYPO3-core] RFC #6958: t3lib_htmlmail.php cleanup

Steffen Kamper steffen at sk-typo3.de
Tue Jan 8 22:45:05 CET 2008


"Benjamin Mack" <mack at xnos.org> schrieb im Newsbeitrag 
news:mailman.2394.1199827416.5304.typo3-team-core at lists.netfielders.de...
> Hey guys,
>
> this is another SVN patch request and I'm back in full swing for TYPO3
> in 2008.
>
> Type: Cleanup
>
> Branches: Trunk only
>
> BT reference: http://bugs.typo3.org/view.php?id=6958
>
> Problem:
> The file t3lib/class.t3lib_htmlmail.php did not have phpDoc style
> comments yet and was quite unusable for documentation purposes.
>
> Solution:
> I added minimal documentation and refactored some code, cleaned up some
> variable names, used foreach instead of the each-while() controls and
> made the code better to read. I also added "public" to every function to
> make it PHP5-like.
>
> Notes:
> I know it's a large patch, but Stefano, Steffen and myself did some
> basic testing with the class and it appears that everything is still
> working. I think we can commit this one after a few people have read the
> patch as it does not change APIs.
>
> -- 
> greetings,
> benni.
> -SDG-

as mentioned i tested with mailform and php snippets using more recipients, 
attachment and plain text, all works for me.
So +1

vg  Steffen 




More information about the TYPO3-team-core mailing list