[TYPO3-core] RFC: Fix (part of) #7589: FULLTEXT keys are not processed correctly

Michael Stucki michael at typo3.org
Thu Feb 28 14:31:24 CET 2008


Hi Moreno,

>>  Another thing: are you sure this is correct:
>>  -$key = str_replace('`', '', $parts[0]);
>>  +// Field definition
>>  +$key = $parts[0];
>>   $total[$table]['fields'][$key] = $parts[1];
>>
>>  You keep backticks around field name. Same thing several line below in
>>  the patch. Not sure if it is a problem. Likely not.
> I think especially with dbal this is a problem.
> 
> Otherwise +1 on reading if you remove these backticks.

As I said, they are still removed.
Since you are running DBAL, can I ask you to check, not only look over this
patch, please?

- michael
-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/


More information about the TYPO3-team-core mailing list