[TYPO3-core] RFC: Fix (part of) #7589: FULLTEXT keys are notprocessed correctly

Steffen Kamper steffen at sk-typo3.de
Thu Feb 28 12:53:28 CET 2008


"Moreno Feltscher" <moreno.feltscher at gmail.com> schrieb im Newsbeitrag 
news:mailman.3760.1204199223.5943.typo3-team-core at lists.netfielders.de...
>>  Another thing: are you sure this is correct:
>>  -$key = str_replace('`', '', $parts[0]);
>>  +// Field definition
>>  +$key = $parts[0];
>>   $total[$table]['fields'][$key] = $parts[1];
>>
>>  You keep backticks around field name. Same thing several line below in 
>> the patch. Not sure if it is a problem. Likely not.
> I think especially with dbal this is a problem.
>
> Otherwise +1 on reading if you remove these backticks.

removing backticks is ok because it's a blocker for DBAL
Should there be a name checking for fields instead or leave it and declare 
such as user error?

vg  Steffen 




More information about the TYPO3-team-core mailing list