[TYPO3-core] RFC: Add missing docheaders to core modules

Michael Stucki michael at typo3.org
Thu Feb 14 20:22:39 CET 2008


Hi Patrick,

good work! I looked at the code of some, however did not try them out. Do
you need more reviews for them?

One thing I noticed was that you broke up Kaspers name (the special chars)
in some PHP headers. Make sure you cross-check them before you commit. (If
you work on Linux, there is "mcedit" which saves files exactly the way they
have been opened. So you can use this one for example to remove the hunks
that changed the name accidentially...)

Just one request: Please commit only one patch at a time, which makes it
easier to review the changes and know what belongs to what...

- michael

Patrick Broens wrote:

> This is a SVN patch request.
> 
> Type: improvement
> 
> Problem:
> Just before the release of beta1 the docheader was added to some
> modules. Not every module, which could need it, has the docheader. Also
> some modules which have a docheader are not displaying it when no page
> has been chosen.
> 
> Solution:
> Add docheaders where they are missing and/or could be needed.
> 
> Note #1:
> This is one RFC with a lot of separate patches. I didn't want to fill
> the list with an RFC for each and every module patch. The attached
> patches are for each module separately. Please review and test them
> separately.
> 
> Note #2:
> Although stated in the BT (http://bugs.typo3.org/view.php?id=7434) I
> don't think the module Task Center needs a docheader. If somebody thinks
> otherwise, let me know.
> 
> Branches:
> Trunk, TYPO3_4.2 (yeah, I know, trunk is closed :-)
> 
> Patrick
> 
> 20080207_RFC_7429.diff: Docheaders: Module Web > Page : No docheader
> when no page has been chosen
> http://bugs.typo3.org/view.php?id=7429
> 
> 20080207_RFC_7430.diff: Docheaders: Module Web > Functions : No
> docheader when no page has been chosen
> http://bugs.typo3.org/view.php?id=7430
> 
> 20080207_RFC_7431.diff: Docheaders: Module Web > Versioning : No
> docheader when no page has been chosen
> http://bugs.typo3.org/view.php?id=7431
> 
> 20080207_RFC_7432.diff: Docheaders: Module Web > Template : No docheader
> when no page has been chosen
> http://bugs.typo3.org/view.php?id=7432
> 
> 20080207_RFC_7433.diff: Docheaders: Module User Tools > User settings :
> No docheader
> http://bugs.typo3.org/view.php?id=7433
> 
> 20080212_RFC_7435.diff: Docheaders: Module User Tools > Workspace: No
> docheader
> http://bugs.typo3.org/view.php?id=7435
> 
> 20080212_RFC_7436.diff: Docheaders: Module Admin tools > User Admin: No
> docheader
> http://bugs.typo3.org/view.php?id=7436
> 
> 20080212_RFC_7437.diff: Docheaders: Module Admin tools > Log: No docheader
> http://bugs.typo3.org/view.php?id=7437
> 
> 20080212_RFC_7438.diff: Docheaders: Module Help > TypoScript Help: No
> docheader
> http://bugs.typo3.org/view.php?id=7438
> 
> 20080212_RFC_7503.diff: Docheaders: Module Admin tools > Ext Manager: No
> docheader
> http://bugs.typo3.org/view.php?id=7503
> 
> 20080212_RFC_7504.diff: Docheaders: Module Admin tools > DB check: No
> docheader
> http://bugs.typo3.org/view.php?id=7504
> 
> 20080212_RFC_7505.diff: Docheaders: Module Admin tools > Configuration:
> No docheader
> http://bugs.typo3.org/view.php?id=7505

-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/


More information about the TYPO3-team-core mailing list