[TYPO3-core] RFC: Cleanup #7388: Gremlins in Taskcenter
Steffen Kamper
steffen at sk-typo3.de
Wed Feb 13 17:32:55 CET 2008
"Jeff Segars" <jsegars at alumni.rice.edu> schrieb im Newsbeitrag
news:mailman.1.1202915590.6901.typo3-team-core at lists.netfielders.de...
> Steffen Kamper wrote:
>> Hi,
>
>> this is a SVN patch request.
>
>> Branches: Trunk
>
>> Bugtracker Reference:
>> http://bugs.typo3.org/view.php?id=7388
>
>> Problem:
>> Taskcenter uses dynTabMenu which has
>> * HTML table layout
>> * obsolete JS-Code
>> * difficult to style
>> * Status of Menu is only saved in temp. JS-Vars
>
>> Solution:
>> I replaced this menu with a normal ul-list and added a prototype
>> script for expand/collapse and the status is saved in Usersettings
>> via Ajax.
>
>> I also removed the height-bug when edit a record in taskcenter.
>
>> vg Steffen
>
> Hey Steffen,
> Thanks for the work on this. Can we open up a new ticket for it
> though? I didn't realize it had been grouped with the other CSS
> gremlins and that patch has already been committed separately. A
> couple other comments from testing...
>
> * We probably need separate styles for typo3/stylesheet and t3skin to
> account for the different color schemes. Right now, it all seems to
> be targeted at t3skin but is in typo3/stylesheet * When Task Center
> data is saved into BE_USER->uc, would a camel-case taskCenter be
> better than TaskCenter to stay consistent with other ->uc data. * I'm
> not sure about the gray background for the active menu item. When I
> look at it, the first thing that comes to mind is that the item is
> disabled. * Can we add the top margin of -1px that we discussed
> earlier to get rid of the two pixel border between list elements?
>
> All minor stuff of course...overall its looking good.
>
> Thanks,
> Jeff
>
>
Hi Jeff,
i made a new BT-entry and created new patch with minor issues you mentioned
above.
I changed also the color of "active" to a nearly white one.
Having styles in stylesheet.css is no good solution, that's right. but we
don't have a guide for that either a skinning interface, stylesheet should
be splitted in single files and be in typo3/css imho.
My styling (colors) are not the final, this is a draft "on the road to
dynTabMenu2" with cleaner HTML and prototype driven :-)
vg Steffen
begin 666 20080209_new_menu_taskcenter2.diff
M26YD97 at Z('1Y<&\S+W-T>6QE<VAE970N8W-S#0H]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]#0HM+2T@='EP;S,O<W1Y;&5S:&5E="YC<W,)*')E=FES:6]N(#,Q
M-3<I#0HK*RL@='EP;S,O<W1Y;&5S:&5E="YC<W,)*'=O<FMI;F<@8V]P>2D-
M"D! ("TU-3 at L-R K-34X+#$X($! #0H at 0D]$62-T>7!O,RUM;V0M=&]O;',M
M96TM:6YD97 at M<&AP(%12+G5N<W5P<&]R=&5D+65X="!41"!!('L at 8V]L;W(Z
M("-F9C P,# [('T*($)/1%DC='EP;S,M;6]D+71O;VQS+65M+6EN9&5X+7!H
M<"!44B!41"YE>'1S=&%T92![(&-O;&]R.B C9F9F.R!F;VYT+7=E:6=H=#H@
M8F]L9#L@=&5X="UA;&EG;CH at 8V5N=&5R.R!]"B **R\J(%1A<VL at 0V5N=&5R
M("HO"BLC97AT+71A<VMC96YT97(M=&%S:RUI;F1E>"UP:' @=6PN=&%S:V-E
M;G1E<BUM;V1U;&4L=6PN=&%S:V-E;G1E<BUM;V1U;&4@;&D@=6P@>VQI<W0M
M<W1Y;&4Z;F]N93MM87)G:6XZ,#MP861D:6YG.C [?0HK(V5X="UT87-K8V5N
M=&5R+71A<VLM:6YD97 at M<&AP('5L+G1A<VMC96YT97(M;6]D=6QE(&QI(&%[
M8W5R<V]R.G!O:6YT97([8F]R9&5R.C%P>"!S;VQI9"!B;&%C:SMB86-K9W)O
M=6YD.B-E964[<&%D9&EN9SHV<'@@,3)P>#MD:7-P;&%Y.F)L;V-K.VUA<F=I
M;BUB;W1T;VTZ+3%P>#M]"BLC97AT+71A<VMC96YT97(M=&%S:RUI;F1E>"UP
M:' @=6PN=&%S:V-E;G1E<BUM;V1U;&4@;&D at 82YA8W1I=F4@>V)A8VMG<F]U
M;F0Z(V9E9F5F93M]"BLC97AT+71A<VMC96YT97(M=&%S:RUI;F1E>"UP:' @
M=6PN=&%S:V-E;G1E<BUM;V1U;&4@;&D at 83IH;W9E<B![8F%C:V=R;W5N9#HC
M9#=D8F4R.WT**R-E>'0M=&%S:V-E;G1E<BUT87-K+6EN9&5X+7!H<"!U;"YT
M87-K8V5N=&5R+6UO9'5L92!L:2!U;"![;6%R9VEN.C5P>" P.WT**R-E>'0M
M=&%S:V-E;G1E<BUT87-K+6EN9&5X+7!H<"!U;"YT87-K8V5N=&5R+6UO9'5L
M92!L:2!U;"!L:2![9&ES<&QA>3IB;&]C:SMP861D:6YG+6QE9G0Z,C1P>#M]
M"BLC97AT+71A<VMC96YT97(M=&%S:RUI;F1E>"UP:' @=6PN=&%S:V-E;G1E
M<BUM;V1U;&4@;&D@=6P@;&D at 82![<&%D9&EN9SHP.V)O<F1E<CIN;VYE.V)A
M8VMG<F]U;F0Z=')A;G-P87)E;G0[9&ES<&QA>3II;FQI;F4[?0HK( HK(V5X
M="UT87-K8V5N=&5R+71A<VLM:6YD97 at M<&AP('MH96EG:'0Z.34E.WT*( HK
M"B O*B!7;W)K<W!A8V4@*B\*(&1I=BYW;W)K<W!A8V4M:6YF;R!["B )<&%D
M9&EN9SH@,'!X(#)P>" P<'@@,G!X.PI);F1E>#H@='EP;S,O<WES97AT+W1A
M<VMC96YT97(O97AT7W1A8FQE<RYP:' -"CT]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T-"BTM+2!T>7!O,R]S>7-E>'0O=&%S:V-E;G1E<B]E>'1?=&%B;&5S+G!H
M< DH<F5V:7-I;VX@,S$U-RD-"BLK*R!T>7!O,R]S>7-E>'0O=&%S:V-E;G1E
M<B]E>'1?=&%B;&5S+G!H< DH=V]R:VEN9R!C;W!Y*0T*0$ @+3(L-" K,BPV
M($! #0H@:68@*"%D969I;F5D("@G5%E03S-?34]$12<I*2 )9&EE("@G06-C
M97-S(&1E;FEE9"XG*3L*( H@:68@*%194$\S7TU/1$4]/2="12<I"70S;&EB
M7V5X=$UG;3HZ861D36]D=6QE*"=U<V5R)RPG=&%S:R<L)W1O<"<L=#-L:6)?
M97AT36=M.CIE>'10871H*"1?15A42T59*2XG=&%S:R\G*3L*+3\^#0I<($YO
M(&YE=VQI;F4 at 870@96YD(&]F(&9I;&4-"BL**R1465!/,U]#3TY&7U9!4E-;
M)T)%)UU;)T%*05 at G75LG5&%S:T-E;G1E<CHZ<V%V94UE;G53=&%T92==(#T@
M=#-L:6)?97AT36=M.CIE>'10871H*"1?15A42T59*2XG=&%S:R]C;&%S<RYM
M;V1?=7-E<E]T87-K+G!H<#IM;V1?=7-E<E]T87-K+3YA:F%X4V%V94UE;G53
M=&%T=7,G.PHK/SX*26YD97 at Z('1Y<&\S+W-Y<V5X="]T87-K8V5N=&5R+W1A
M<VLO8VQA<W,N;6]D7W5S97)?=&%S:RYP:' -"CT]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T-"BTM+2!T>7!O,R]S>7-E>'0O=&%S:V-E;G1E<B]T87-K+V-L87-S
M+FUO9%]U<V5R7W1A<VLN<&AP"2AR979I<VEO;B S,34W*0T**RLK('1Y<&\S
M+W-Y<V5X="]T87-K8V5N=&5R+W1A<VLO8VQA<W,N;6]D7W5S97)?=&%S:RYP
M:' )*'=O<FMI;F<@8V]P>2D-"D! ("TR,#,L." K,C S+#$W($! #0H@"69U
M;F-T:6]N('5R;$EN269R86UE*"1U<FPL)&UA>#TP*2!["B )"7)E='5R;B G
M/&EF<F%M92!O;FQO860](G)E<VEZ94EF<F%M92AT:&ES+"<N)&UA>"XG*3LB
M('-C<F]L;&EN9STB875T;R(@=VED=&@](C$P,"4B('-R8STB)RXD=7)L+B<B
M(&YA;64](FQI<W1?9G)A;64B(&9R86UE8F]R9&5R/2)N;R(@<W1Y;&4](F)O
M<F1E<CH@;F]N93LB/CPO:69R86UE/B<["B )?0HK"0HK"0HK"69U;F-T:6]N
M(&%J87A3879E365N=5-T871U<R at D<&%R86US(#T at 87)R87DH*2P at 5%E03S-!
M2D%8("8D86IA>$]B:B ](&YU;&PI('L**PD))&UE;G5I9" ]('0S;&EB7V1I
M=CHZ7U!/4U0H)VUE;G5I9"<I.PHK"0DD<W1A=&4@/2!T,VQI8E]D:78Z.E]0
M3U-4*"=S=&%T92<I(#T]/2 G=')U92<@/R P(#H@,3L**PD)"BL)"21'3$]"
M04Q36R="15]54T52)UTM/G5C6R=M;V1U;&5$871A)UU;)W1A<VM#96YT97(G
M75LD;65N=6ED72 ]("1S=&%T93L**PD))$=,3T)!3%-;)T)%7U5315(G72T^
M=6-;)VUO9'5L941A=&$G75LG=&%S:T-E;G1E<B==6R=A8W1I=F4G72 ]("1M
M96YU:60["BL)"21'3$]"04Q36R="15]54T52)UTM/G=R:71E54,H*3L**PE]
M"B *+0H@?0H@"B O+R!);F-L=61E(&5X=&5N<VEO;C\*26YD97 at Z('1Y<&\S
M+W-Y<V5X="]T87-K8V5N=&5R+W1A<VLO:6YD97 at N<&AP#0H]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]#0HM+2T@='EP;S,O<WES97AT+W1A<VMC96YT97(O=&%S
M:R]I;F1E>"YP:' )*')E=FES:6]N(#,Q-3<I#0HK*RL@='EP;S,O<WES97AT
M+W1A<VMC96YT97(O=&%S:R]I;F1E>"YP:' )*'=O<FMI;F<@8V]P>2D-"D!
M("TY,BPV("LY,BPX($! #0H@"0DD=&AI<RT^9&]C(#T@=#-L:6)?9&EV.CIM
M86ME26YS=&%N8V4H)VYO1&]C)RD["B )"21T:&ES+3YD;V,M/F1O8U1Y<&4@
M/2 G>&AT;6Q?=')A;G,G.PH@"0DD=&AI<RT^9&]C+3YD:79#;&%S<R ]("<G
M.PHK"0D**PD)"B )"21T:&ES+3YD;V,M/F9O<FT@/2 G/&9O<FT at 86-T:6]N
M/2)I;F1E>"YP:' B(&UE=&AO9#TB4$]35"(@;F%M93TB961I=&9O<FTB/B<[
M"B )"21T:&ES+3YB86-K4&%T:" ]("1T:&ES+3YD;V,M/F)A8VM0871H(#T@
M)$)!0TM?4$%42#L*( D))'1H:7,M/F1O8RT^2E-C;V1E(#T@)R @/'-C<FEP
M="!L86YG=6%G93TB:F%V87-C<FEP="(@='EP93TB=&5X="]J879A<V-R:7!T
M(CX*0$ @+3$P,BPW("LQ,#0L."! 0 T*( D)"2<N*&ES7V]B:F5C="@D=&AI
M<RT^97AT3V)J*3\D=&AI<RT^97AT3V)J+3Y*4V-O9&4H*3HB(BDN)PH@"0D)
M/"]S8W)I<'0^"B )"0DG.PHM"0DD=&AI<RT^9&]C+3Y*4V-O9&4 at +CT@)'1H
M:7,M/F1O8RT^9V5T1'EN5&%B365N=4I38V]D92 at I.PHK"BL)"21T:&ES+3YD
M;V,M/FQO861*879A<V-R:7!T3&EB*"=C;VYT<FEB+W!R;W1O='EP92]P<F]T
M;W1Y<&4N:G,G*3L*( D))'1H:7,M/F1O8RT^2E-C;V1E("X]("<\<V-R:7!T
M(&QA;F=U86=E/2)J879A<V-R:7!T(B!T>7!E/2)T97AT+VIA=F%S8W)I<'0B
M/@H@"0EF=6YC=&EO;B!R97-I>F5)9G)A;64H9G)A;64L;6%X*2!["B )"0ET
M<GD@>PI 0" M,3$W+#<@*S$R,"PY($! #0H@"0D)"7=I;F1O=RYS=&%T=7,@
M/2!E+FUE<W-A9V4["B )"0E]"B )"7T*+3PO<V-R:7!T/B<["BL\+W-C<FEP
M=#X**SQS8W)I<'0@='EP93TB=&5X="]J879A<V-R:7!T(B!S<F,](B<N)$)!
M0TM?4$%42"YT,VQI8E]E>'1-9VTZ.F5X=%)E;%!A=&@H)W1A<VMC96YT97(G
M*2XG5&%S:T-E;G1E<DUE;G4N:G,B/CPO<V-R:7!T/@D**PD))SL*( H@"0DO
M*B!C86QL(&=E=$UA:6Y#;VYT96YT(&9I<G-T+"!B96-A=7-E('=H870@:&%P
M<&5N<R!H97)E(&UI9VAT(&%F9F5C="!L969T0V]N=&5N=" J+PH@"0DD;6%I
M;D-O;G1E;G0@/2 D=&AI<RT^9V5T36%I;D-O;G1E;G0H*3L*0$ @+3$T,"PV
M("LQ-#4L."! 0 T*( D)+R]W86QK('1H<F]U9V@@<F5G:7-T97)E9"!S=6)M
M;V1U;&5S(&%N9"!G96YE<F%T92!C;VYF:6=U<F%T:6]N"B )"2\O9F]R('1A
M8FUE;G4*( D))'!A<G1S(#T at 07)R87DH*3L**PD))&D],#L**PD))&]U='!U
M=" N/2 G/'5L(&-L87-S/2)T87-K8V5N=&5R+6UO9'5L92(^)SL*( D)9F]R
M96%C:"@D=&AI<RT^86QL17AT0VQA<W-#;VYF(&%S("1C;VYF*2!["B )"0DD
M97AT3V)J(#T@=#-L:6)?9&EV.CIM86ME26YS=&%N8V4H)&-O;F9;)VYA;64G
M72D["B )"0DO*B!C86QL(&EN:70@=&\@;6%K92!S=7)E('1H92!,3T-!3%],
M04Y'(&ES(&EN8VQU9&5D(&9O<B!A;&P@;&ES=&5D"D! ("TQ-#DL,3 @*S$U
M-BPR-"! 0 T*( D)"21E>'1/8FHM/FUO9%]U<V5R7W1A<VM?:6YI="@D1TQ/
M0D%,4ULG0D5?55-%4B==*3L*( D)"21P87)T(#T@)&5X=$]B:BT^;W9E<G9I
M97=?;6%I;B at I.PH@"0D):68@*&ES7V%R<F%Y*"1P87)T*2D@>PHM"0D)"21P
M87)T<UM=(#T@)'!A<G0["BL)"0D))'!A<G1S6R1I*RM=(#T@)'!A<G0["BL)
M"0D))'-T871U<R ](&EN='9A;"@D1TQ/0D%,4ULG0D5?55-%4B==+3YU8ULG
M;6]D=6QE1&%T82==6R=487-K0V5N=&5R)UU;)W1A<VMC96YT97(M;6]D=6QE
M+6AE861E<BTG+B1I72D["BL)"0D))&%C=&EV94E$(#T@*"1'3$]"04Q36R="
M15]54T52)UTM/G5C6R=M;V1U;&5$871A)UU;)U1A<VM#96YT97(G75LG86-T
M:79E)UT@/3T]("=T87-K8V5N=&5R+6UO9'5L92UH96%D97(M)RXD:2D["BL)
M"0D)"BL)"0D))&]U='!U=" N/2<\;&D at 8VQA<W,](G1A<VMC96YT97(M;6]D
M=6QE+6AE861E<B(@:60](G1A<VMC96YT97(M;6]D=6QE+6AE861E<BTG+B1I
M+B<B/CQA(&AR968](B,B)RXH)&%C=&EV94E$(#\@)R!C;&%S<STB86-T:79E
M(B<@.B G)RDN)SXG+B1P87)T6R=I8V]N)UTN)SPO83XG.PHK"0D)"6EF*&ES
M<V5T*"1P87)T6R=C;VYT96YT)UTI*2!["BL)"0D)"21I=&5M<SUE>'!L;V1E
M*"<\0E(^)RPD<&%R=%LG8V]N=&5N="==*3L**PD)"0D))&]U='!U=" N/2 G
M/'5L)RXH)'-T871U<ST],2 _("<@<W1Y;&4](F1I<W!L87DZ;F]N93LB)R Z
M("<G*2XG/B<["BL)"0D)"69O<F5A8V at H)&ET96US(&%S("1I=&5M*2!["BL)
M"0D)"0EI9B at D:71E;2D@)&]U='!U=" N/2 G/&QI/B<N)&ET96TN)SPO;&D^
M)SL**PD)"0D)?0HK"0D)"0DD;W5T<'5T("X]("<\+W5L/B<["BL)"0D)?0HK
M"0D)"21O=71P=70 at +CT@)SPO;&D^)SL*( D)"7T*( D)?0HM"0ER971U<FX@
M)'1H:7,M/F1O8RT^9V5T1'EN5&%B365N=2 at D<&%R=',L("=T>%]T87-K8V5N
M=&5R)RP@,2P@=')U92D["BL)"21O=71P=70 at +CT@)SPO=6P^)SL**PD)<F5T
M=7)N("1O=71P=70["B )?0H@"B )+RHJ"D! ("TQ.#@L-R K,C Y+#@@0$ -
M"B )"21T:&ES+3YC;VYT96YT("X]("1T:&ES+3YD;V,M/F5N9%!A9V4H*3L*
K( D)96-H;R D=&AI<RT^8V]N=&5N=#L*( E]"BT**PD**PD*('T*( H@"@``
`
end
More information about the TYPO3-team-core
mailing list