[TYPO3-core] RFC: Feature #4923: provide new inputfield "directorypicker" in BE
Ernesto Baschny [cron IT]
ernst at cron-it.de
Mon Feb 4 21:13:22 CET 2008
Ralf Hettinger wrote: on 31.01.2008 19:35:
> thanks for digging that deep, I will have a look at that next week. Nevertheless
> I think a "single" dirpicker could be solved better by using not an input field
> with "strange" wizard GET params but rather a single group field.
>
> The input field used as dirpicker is somewhat an already deprecated thing
> suggested by the very first dirpicker-demo extension, I would think.
>
> I added a new dirpicker demo to http://bugs.typo3.org/view.php?id=4923 , that
> doesn't use an input field with ?mode=folder GP but a single group field. Which
> I think should be the way such a dirpicker is used and the one that should be
> concentrated on when testing for reliability.
>
> Would be happy to hear if that part works for you.
Yes, that did work!
Before I give out a +1, I would like to review the code a bit. Maybe you
could create a new patch which could be reviewed. Because on the
original one I read:
+ if ($this->mode=='wizard' || $this->mode=='folder')
which is what Dmitry pointed out as being "bad", and which probably is
of use for the wizard added in the original dirpicker. So if this is not
needed anymore, maybe the code can be cleaned up a bit before we further
review it. Post that as a reply to your original thread-initiation, so
that it doesn't go overlooked inside a deep thread. :)
Thanks!
But I also would welcome a way to have a single input-field marked as a
dir-picker so one could type (maybe even with directory auto-completion)
and a popup-wizard for selecting the directory. But we could postpone
that for later.
Cheers,
Ernesto
More information about the TYPO3-team-core
mailing list