[TYPO3-core] RFC: #7350:PHP5ize class.t3lib_div.php

[Martin Kutschker]

Michael Stucki schrieb:
> Hi Masi,
> 
>> The final patch is attached. I did the same to split_tag_attributes and
>> added some code cleanup.
> 
> Just one question:
> 
> You added this line:
> 
> +       if (preg_match('/^\s*<\?xml([^>]*)\?\>/', $xmlData, $match))    {
> 
> There is no sense in allowing whitespaces before the opening tag, right?

It was there before. The old code had a trim() before doing the match. 
I'm not sure if any white space before the prologue is allowed (I think 
not), but I think it's better to be a bit relaxed in what we accept as 
input.

Masi