[TYPO3-core] RFC: #7350:PHP5ize class.t3lib_div.php

Michael Stucki michael at typo3.org
Sun Feb 3 11:32:08 CET 2008


Hi Masi,

> The final patch is attached. I did the same to split_tag_attributes and
> added some code cleanup.

Just one question:

You added this line:

+       if (preg_match('/^\s*<\?xml([^>]*)\?\>/', $xmlData, $match))    {

There is no sense in allowing whitespaces before the opening tag, right?
I suggest you remove it.

- michael
-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/


More information about the TYPO3-team-core mailing list