[TYPO3-core] RFC: #7337: stdWrap for menu > range & entrylevel

[Uschi Renziehausen]

Hi Michael and the rest,

@Michael: You spoiled my day by being so dramatic ;-(
I tested with Steffens patch and redid my menus with that one last night 
after I saw that it was committed to trunk and meant to switch to head 
revision this morning when I saw that you removed it.


Michael Stucki wrote:
> 
> Additionally, I see that the stdWrap for "range" has not been documented.
> Reading this discussion I see that Georg "thinks" that it is fine, however
> there is no mention of it on the Wiki page.
>

If it was up to me, I would split up the whole special table into one 
for each special property. This would improve the readability of that 
section a lot, because the datatype of each subproperty could be in the 
datatype column and the description column would be less crouded and 
could have examples. Also one could navigate more easily if there were 
seperate headlines like 'special.directory'. Also one could give a short 
explanation of what each special property does OUTSIDE of any table.
What do you think? I am willing to help with this if you like the idea 
and someone tells me how to proceed.

I meant to put a line into the Wiki about range yesterday night but then 
thought that this would be wrong if the text of documentation is not 
changed at all for range. Perhaps there should be a convention of how to 
make clear the datatype of those subproperties mentioned only in the 
description column, because that info is missing in quite a few places.

Now, can someone please be so kind and fix that issue so that it can be 
back in trunk?

Prosit, (a very sad) Uschi

> Folks, please accept that documentation must gain the same high priority like
> development has. If you are lazy about this, then you probably have to
> rethink if you want to be in the core team.
> 
> I do my best to review changes like this one, but it seems likely that I
> overlook something, so we cannot rely on this!
> 
>> I added the stdWrap for entryLevel also at another line in tslib_menu.php
>> so there is one more change in the commited version ...
> 
> Hunk #2 is faulty:
> 
> @@ -607,7 +607,7 @@
>                                                         $extraWhere.= ' AND pages.no_search=0';
>                                                 }
>                                                         // start point
> -                                               $eLevel = tslib_cObj::getKey (intval($this->conf['special.']['entryLevel']),$this->tmpl->rootLine);
> +                                               $eLevel = tslib_cObj::getKey ($this->parent_cObj->stdWrap($conf['entryLevel'], $conf['entryLevel.']),$this->tmpl->rootLine);
>                                                 $startUid = intval($this->tmpl->rootLine[$eLevel]['uid']);
> 
>                                                         // which field is for keywords
> 
> I have reverted the commit and removed the documentation until it is fixed.
> 
> Sorry to be so dramatic, but the subject is important.
> 
> - michael