[TYPO3-core] RFC: #7265: Submodules of Web module can't work with mod.php and the _DISPATCH system

[Franz Holzinger]

Hello Steffen,

Steffen Kamper a écrit :

> Franz Holzinger schrieb:
>> Hello Steffen,
>>
>>> Attached is the complete v2-patch
>>>
>>> For more info how to use mod.php read here:
>>> http://lists.netfielders.de/pipermail/typo3-team-core/2007-March/007751.html 
>>
>>
>>
>> Good improvement.
>>
>> typo3/template.php:
>>
>> if (($temp_M = (string) t3lib_div::_GET('M'))
>>
>> It is not good to make an assignement inside of an IF clause.
>> It would be fine to have a common variable $path to avoid duplicate code.
>>
> 
> this is only a temp var to be used in the second line, where the common 
> var $this->scriptID is filled:

Even in this case it is hard to read that there is an assignement inside 
of the IF clause. And it is generally dangerous to use an

if ($variable=$value)

comparison, because in most cases you wanted to have a

if ($variable == $value)

instead and no assignment.


- Franz