[TYPO3-core] RFC: #9109: Enable feature in element browser in rte like in normal one
Steffen Kamper
info at sk-typo3.de
Mon Aug 11 19:48:05 CEST 2008
Stanislas Rolland schrieb:
> Hi Steffen,
>>
>> this is indeed and it's by design of Kasper's original patch.
>> Page mounts are replacing the original. This makes sense for
>> preventing double page trees. The normal usecase is that you add some
>> root pages where user normally doesn't has access while his page
>> mounts are part of this root pages.
> Just a bit confusing that the two options do not behave the same way.
> This needs to be well documented in Page TSConfig.
>
>>
>> The error with the upload is correct. A followup patch should check
>> the "readOnly" flag of current filemount when showing upload fields.
>>
> It seems that in the base class (class.browse_links.php), the upload
> form is never shown whatever the current filemount. Not sure this is how
> it should be. It would be nicer if it would be available when the user
> has update rights. In fact, if uploadForm($path) and createFolder($path)
> were to return an empty string when not allowed for the $path, this
> would take care of the EB and RTE at once (but not DAM which has its own
> forms).
>
> Some additional comments:
> In typo3/browse_links.php and rtehtmlarea/mod3/browse_links.php, it
> would be better if mountpoints were set before the browserRendering
> hooks are invoked. In the case of RTE image insertion, setting
> filemounts should be done in rtehtmlarea/mod4/select_image.php (also
> before browserRendering hooks are invoked), not in
> class.tx_rtehtmlarea_select_image.php. With these changes to the patch,
> the feature would be correctly handled by DAM as well, in all cases,
> without any change to DAM.
>
> Kind regards,
> Stanislas
>
>
Hi Stan,
i will check that and try making the check before. i remember having
problems with an earlier point, but hope to get the right one :-)
vg Steffen
More information about the TYPO3-team-core
mailing list