[TYPO3-core] RFC: #7986: Vertical aligned Icons in List-Module

[Ingo Renner]

Hi all,

I'm currently reviewing version 9 of this patch. To be honest codewise 
it's sometimes very messy - like we never had a CGL! I'm wondering, did 
nobody else look at the code?

@Steffen fix your editor to not add a new line at the end of files!

@all:
Whoever wrote that line:

$rowSpecial = $cc == 1 && $indent == 0 ? ' firstcol' : '' . ($cc == 
$this->totalRowCount || $cc == $this->iLimit ? ' lastcol' : '');

(class.db_list_extra.inc, 5th hunk)

fix it by splitting that statement up - nobody will ever understand that 
in case we have to!

Who introduces stupid variable names like $theIcon? Damn! Choose good 
variable names even when old ones exist that are stupid, this is no 
reason to repeat those stupid names! What spoke against $icon?

This line needs to get slit up, too:
$spaceIcon = '<img src="' . $this->backPath . 'clear.gif" width="' . 
($GLOBALS['TBE_STYLES']['skinImgAutoCfg']['iconSizeWidth']?$GLOBALS['TBE_STYLES']['skinImgAutoCfg']['iconSizeWidth']:12) 
. '" height="' . 
($GLOBALS['TBE_STYLES']['skinImgAutoCfg']['iconSizeHeight']?$GLOBALS['TBE_STYLES']['skinImgAutoCfg']['iconSizeHeight']:12) 
. '" title="" alt="" />';

Dudes, are you kidding? (still class.db_list_extra.inc)

Next point: since when do we use space to indent at the beginning of 
lines? (typo3/stylesheet.css, typo3/sysext/t3skin/ext_tables.php, 
typo3/sysext/t3skin/stylesheets/typo3-db-list-php.css)

Also: What happened to the rollover?
-table.typo3-dblist tr:hover,
-table.typo3-dblist tr:hover td.db_list_alt,
-table.typo3-page-stdlist tr:hover,
-table.typo3-page-stdlist tr:hover td.db_list_alt {
-	background-color: #d7dbe2;
-}

(typo3/sysext/t3skin/stylesheets/typo3-db-list-php.css)



I attached a version of the patch that is cleaned up except for the 
mentioned points.

Ingo

-- 
Ingo Renner
TYPO3 Core Developer, Release Manager TYPO3 4.2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 7986_cleaned.diff
Type: text/x-diff
Size: 28471 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080411/14427ef2/attachment-0001.diff