[TYPO3-core] RFC: #8014: remove empty tabs from TCEForms

[Steffen Kamper]

Hi Malte,

"Malte Jansen" <mail at maltejansen.de> schrieb im Newsbeitrag 
news:mailman.1.1207497853.23892.typo3-team-core at lists.netfielders.de...
> Hi Benni,
>
> Benjamin Mack schrieb:
>> Hey Malte,
>>
>> thanks a lot for your input.
>>
>> What I mentioned in my other post is that I think we should have a
>> different treatment of dynTabMenus where they occur.
>>
>> a) the default behaviour in template.php is to "disable", not to
>> "remove" empty tabs. We should not change this because it would break
>> backwards compatibility. We experienced problems e.g. in the taskcenter.
>
> The default behavior is set to disableTabs in dynTabMenus of
> template.php. It's set with the last parameter which is set to "2".
>
>> b) BUT we could set the behaviour for TCEforms specifically, where
>> disabled empty tabs do not make a lot of sense. So it would be the best
>> to change all occurences in the tables.php of the core to dividersToTabs
>> = 2, and that would solve all problems then, right?
>
> In the TCEforms the default behavor WAS removing empty tabs ("1"). Due
> to a patch it does not work anymore.
>
i think it's a bug there. If you use the function getDynTabMenu with an 
uninitialized value or with 0 it hasn't the default behaviour, so i would 
change it there:
function getDynTabMenu($menuItems,...,$dividers2tabs=1) {
       // ensure to remove empty tabs if value is 0
   $dividers2tabs = intval($dividers2tabs)==0 ? 1 : intval($dividers2tabs);

So it works for all calls in same manner.
I included a patch with this change.

btw - you don't need to shout loud ;-) I didn't remembered this change and 
fixed with debugging only. So it's good to have this list, and if something 
goes wrong it will be changed.

vg  Steffen



begin 666 8014_v2.diff
M26YD97 at Z('0S;&EB+V-L87-S+G0S;&EB7W1C969O<FUS+G!H< T*/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/0T*+2TM('0S;&EB+V-L87-S+G0S;&EB7W1C969O
M<FUS+G!H< DH<F5V:7-I;VX@,S4S-"D-"BLK*R!T,VQI8B]C;&%S<RYT,VQI
M8E]T8V5F;W)M<RYP:' )*'=O<FMI;F<@8V]P>2D-"D! ("TV-3<L,30@*S8U
M-RPQ,R! 0 T*( D)"0EI9B H)&-O;G1E;G0I('L*( D)"0D)+R\@5W)A<"!C
M;VYT96YT("AR;W<I('=I=&@@=&%B;&4M=&%G+"!O=&AE<G=I<V4@=&%B+W-H
M965T('=I;&P at 8F4@9&ES86)L960@*'-E92!G971D>6Y486)-96YU*"D@*0H@
M"0D)"0DD8V]N=&5N=" ]("<\=&%B;&4 at 8F]R9&5R/2(P(B!C96QL<W!A8VEN
M9STB,"(@8V5L;'!A9&1I;F<](C B('=I9'1H/2(Q,# E(CXG+B1C;VYT96YT
M+B<\+W1A8FQE/B<["BT)"0D)"21P87)T<ULD:61X72 ](&%R<F%Y* HM"0D)
M"0D))VQA8F5L)R ]/B D;W5T7V%R<F%Y7VUE=&%;)&ED>%U;)W1I=&QE)UTL
M"BT)"0D)"0DG8V]N=&5N="<@/3X@)&-O;G1E;G0L"BT)"0D)"0DG;F5W;&EN
M92<@/3X@)&]U=%]A<G)A>5]M971A6R1I9'A=6R=N97=L:6YE)UTL( DO+R!.
M97=L:6YE(&9O<B!T:&ES('1A8B]S:&5E= HM"0D)"0DI.PH@( D)"0E]( HK
M"0D)"21P87)T<ULD:61X72 ](&%R<F%Y* HK"0D)"0DG;&%B96PG(#T^("1O
M=71?87)R87E?;65T85LD:61X75LG=&ET;&4G72P**PD)"0D))V-O;G1E;G0G
M(#T^("1C;VYT96YT+ HK"0D)"0DG;F5W;&EN92<@/3X@)&]U=%]A<G)A>5]M
M971A6R1I9'A=6R=N97=L:6YE)UTL( DO+R!.97=L:6YE(&9O<B!T:&ES('1A
M8B]S:&5E= HK"0D)"2D["0D)"0H@"0D)"0HM"0D)"0H@"0D)?0H@"B )"0EI
M9B H8V]U;G0H)'!A<G1S*2 ^(#$I('L*26YD97 at Z('1Y<&\S+W1E;7!L871E
M+G!H< T*/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/0T*+2TM('1Y<&\S+W1E;7!L
M871E+G!H< DH<F5V:7-I;VX@,S4S-"D-"BLK*R!T>7!O,R]T96UP;&%T92YP
M:' )*'=O<FMI;F<@8V]P>2D-"D! ("TQ-#$Y+#D@*S$T,3DL,3$@0$ -"B )
M("H at 0'!A<F%M"6EN=&5G97()"4EF('-E="!T;R G,2<@96UP='D@=&%B<R!W
M:6QL(&)E(')E;6]V92P at 268@<V5T('1O("<R)R!E;7!T>2!T86)S('=I;&P@
M8F4 at 9&ES86)L960*( D@*B! <F5T=7)N"7-T<FEN9PD)2F%V85-C<FEP="!S
M96-T:6]N(&9O<B!T:&4 at 2%1-3"!H96%D97(N"B )("HO"BT)9G5N8W1I;VX@
M9V5T1'EN5&%B365N=2 at D;65N=4ET96US+"1I9&5N=%-T<FEN9RPD=&]G9VQE
M/3 L)&9O;&1O=70]1D%,4T4L)&YE=U)O=T-H87),:6UI=#TU,"PD;F]7<F%P
M/3$L)&9U;&Q7:61T:#U&04Q312PD9&5F875L=%1A8DEN9&5X/3$L)&1I=FED
M97)S,G1A8G,],BD)>PHK"69U;F-T:6]N(&=E=$1Y;E1A8DUE;G4H)&UE;G5)
M=&5M<RPD:61E;G13=')I;F<L)'1O9V=L93TP+"1F;VQD;W5T/49!3%-%+"1N
M97=2;W=#:&%R3&EM:70]-3 L)&YO5W)A<#TQ+"1F=6QL5VED=&@]1D%,4T4L
M)&1E9F%U;'1486));F1E>#TQ+"1D:79I9&5R<S)T86)S/3$I"7L*( D))&-O
M;G1E;G0@/2 G)SL*+0HK"0D)+R\@96YS=7)E('1O(')E;6]V92!E;7!T>2!T
M86)S(&EF('9A;'5E(&ES(# **PD))&1I=FED97)S,G1A8G,@/2!I;G1V86PH
M)&1I=FED97)S,G1A8G,I/3TP(#\@,2 Z(&EN='9A;"@D9&EV:61E<G,R=&%B
M<RD["BL)"0H@"0EI9B H:7-?87)R87DH)&UE;G5)=&5M<RDI"7L*( H@"0D)
*"2\O($EN:70Z"@``
`
end