[TYPO3-core] RFC: #7820: Task center iframes are only sized on load
Jeff Segars
jsegars at alumni.rice.edu
Tue Apr 1 16:52:03 CEST 2008
Steffen Kamper wrote:
> attached is new patch with the right condition for IE6
>
> vg Steffen
>
> "Steffen Kamper" <steffen at sk-typo3.de> schrieb im Newsbeitrag
> news:mailman.1.1205255556.30534.typo3-team-core at lists.netfielders.de...
>> Hi,
>>
>> this is a SVN patch request.
>>
>> Type: Bugfix
>>
>> Branches: 4_2
>>
>> Bugtracker Reference:
>> http://bugs.typo3.org/view.php?id=7820
>> http://bugs.typo3.org/view.php?id=7291
>>
>> Problem:
>> Within the task center, iframes are used to include external content such
>> as a TCE form for editing records as part of sys_action. These iframes
>> have an onload attribute to set the height of the form, but this event
>> handler could be improved.
>>
>> Other iframes within the new backend are automatically resized when the
>> browser window is resized (via Prototype event handlers) so the task
>> center should get this same behavior.
>>
>> Solution:
>> I used prototype to calc the right height (former method failed in IE)
>> Additionally i added a resize-handler. I'd exclude IE6 because the handler
>> crashes IE6, problem seem the other resizehandlers (i counted 3)
>>
>> Remark:
>> Former method used to parameters: frame and max. Both are not needed now.
>> The frame is fetched with the id and max is ignored as it ever uses
>> complete height of the doc for the iframe (i only saw a difference of 30
>> pixels before)
>>
>> vg Steffen
>>
>> vg Steffen
I've just given this one last round of testing and committed to 4.2.
Thanks for the patch Steffen and for the testing Krystian.
More information about the TYPO3-team-core
mailing list