[TYPO3-core] RFC: Hide empty TDynTabs

[Benjamin Mack]

Works like a charm.

+1 based upon testing.

and +1 for no configuration option.

greetings,
benni.
-SDG-

www.xnos.de // www.xnos.org


Michael Stucki wrote:
> Hi Bernhard,
> 
> nice to have you back on this list!
> 
>>> I would also like to see more changes like that turned "on" by default
>>> too. I agree with Kasper here. This in particular to me looks more like
>>> a bug than a feature, so I would even ask why do we need to have this
>>> configurable? Who needs empty tabs?? Ever seen a desktop GUI application
>>> with empty tabs??
>> This is also my opinion. If its just me I would simply change the
>> situation to not showing empty Tabs at all. Meaning without the possiblity
>> to configure this.
>>
>> Because I also think its rather a bug than a feature to have empty Tabs :)
> 
> I fully agree! We don't need a configuration switch for that. There are more
> than plenty of them already...
> 
>> so if it's ok for you (any +1 ?) I will simply add the code without any
>> configuration option - and write down in Changelog that in new versions
>> empty tabs are hidden
> 
> It's basically ok, but I found one problem in this patch:
> 
> In t3lib_tceforms, you are returning directly if there is only one tab.
> However, this is bad because the output of this method should return table
> rows (content wrapped in <tr> elements).
> 
> I have fixed this in the attached patch which is ready to be committed. Feel
> free to take it over, please :-)
> 
> - michael
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.netfielders.de
> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-core