[TYPO3-core] RFC: Hide empty TDynTabs

Michael Stucki michael at typo3.org
Mon Sep 10 10:40:05 CEST 2007


Hi Bernhard,

nice to have you back on this list!

>> I would also like to see more changes like that turned "on" by default
>> too. I agree with Kasper here. This in particular to me looks more like
>> a bug than a feature, so I would even ask why do we need to have this
>> configurable? Who needs empty tabs?? Ever seen a desktop GUI application
>> with empty tabs??
> 
> This is also my opinion. If its just me I would simply change the
> situation to not showing empty Tabs at all. Meaning without the possiblity
> to configure this.
> 
> Because I also think its rather a bug than a feature to have empty Tabs :)

I fully agree! We don't need a configuration switch for that. There are more
than plenty of them already...

> so if it's ok for you (any +1 ?) I will simply add the code without any
> configuration option - and write down in Changelog that in new versions
> empty tabs are hidden

It's basically ok, but I found one problem in this patch:

In t3lib_tceforms, you are returning directly if there is only one tab.
However, this is bad because the output of this method should return table
rows (content wrapped in <tr> elements).

I have fixed this in the attached patch which is ready to be committed. Feel
free to take it over, please :-)

- michael
-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hideTabs_2007-09-06_stucki.diff
Type: text/x-diff
Size: 5786 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20070910/143950ec/attachment-0002.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hideTabs_2007-09-06_stucki_w.diff
Type: text/x-diff
Size: 2187 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20070910/143950ec/attachment-0003.diff 


More information about the TYPO3-team-core mailing list