[TYPO3-core] RFC: Fix Bug #4832 - Patch for ter_update_check into EM
Helmut Hummel
typo3 at rampenlicht.org
Mon Oct 29 12:13:36 CET 2007
Hi,
Dmitry Dulepov [typo3] schrieb:
> Helmut Hummel wrote:
>> My version of patch is stripping them automatically, the version of
>> Dmitry obviosly not. We should send patches only with unix file endings.
>>
>> To avoid such things in future, all php files in repository should have
>> the "eol-style: LF" property set...
>
> Currently it has "native" as value, which I believe is bad.
agreed
> We should work and commit only with Unix-like files
agreed
> and the property can be removed completely.
disagreed!
> "native" just creates problems, not helps.
Setting the property to "eol-style: LF" would asure the files are
handled as text, but in UNIX file format.
>> Just to make sure, I attached the last patch from christian with CRs
>> stripped. Can you test if this patch applies correctly Dmitry?
>
> Applied fine :)
fine :)
> Looks and works great. My +1.
Applied 20071028_ter_update_check.patch to my 4.1.3 installations and
tested intensly. Really works great, so I would give a +1 based on
testing, too
Regards Helmut
More information about the TYPO3-team-core
mailing list