[TYPO3-core] RFC: #4662 PAGE_TARGET =

Thu Oct 25 12:18:42 CEST 2007

Hi Benni,

"Benjamin Mack" <mack at xnos.org> schrieb im Newsbeitrag 
news:mailman.3332.1193297755.20721.typo3-team-core at lists.netfielders.de...
> Hey Steffen,
>
> looks almost perfect... Just attach your patch to the email here next time 
> ;-)
>
it's attached ;-)

> The only remarks I have is for the text in the update wizard. I think it's 
> not clear what is meant:
> 'title' => 'CSS Styled Content: Default targets for non-frame pages',
> Title: CSS Styled Content: Default link targets now set for non-frame 
> pages'
> or something (I don't think my solution is the best either ;-))
>
> Description: The default page target is empty (so no target attribute in 
> the anchors is generated). If you use frames, you have to set it to "page" 
> in the TS Constants section.'
>
> What do you think?
>
I'm open for each better formulation, as i'm not a native english speaker i 
would prefer better ones.
I asked Jeff before if it's right use.

> I'm also gonna test your patch within the next days to see if it works :)
>
great, thx.

vg  Steffen

> greetings,
> benni.
> -SDG-
>
> www.xnos.de // www.xnos.org
>
>
> Steffen Kamper wrote:
>> *maybe final version*
>>
>> This is a SVN patch request.
>>
>> Type: ENHANCEMENT
>>
>> Bugtracker references:
>> http://bugs.typo3.org/view.php?id=4662
>>
>>
>> Branches:
>> Trunk
>>
>> typo3/sysext/css_styled_content/static/constants.txt
>> typo3/sysext/css_styled_content/static/setup.txt
>> typo3/sysext/css_styled_content/ext_localconf.php
>>
>> Problem:
>>
>> default setting for PAGE_TARGET is page. This is an old setting for 
>> frames,
>> nowadays it's obsolete.
>> Second tt_content.menu uses as target pageFrameObj which is obsolete too.
>>
>> Solution:
>>
>> setting in CONSTANTS:
>> [compatVersion = 4.2.0]
>> PAGE_TARGET =
>> content.pageFrameObj >
>> [end]
>>
>> setting in SETUP
>> [compatVersion = 4.2.0]
>> tt_content.menu.20.default.1.target = {$PAGE_TARGET}
>> tt_content.menu.20.2.1.target = {$PAGE_TARGET}
>> [end]
>>
>> remarks for update wizard
>>
>> $TYPO3_CONF_VARS['SC_OPTIONS']['ext/install']['compat_version']['tx_cssstyledcontent_pagetargets'] 
>> = array(
>>     'title' => 'CSS Styled Content: Default targets for non-frame pages',
>>     'version' => 4200000,
>>     'description' => '<p>The default page target is empty (so no target 
>> is generated). If you use frames, you have to set it to page in 
>> Constants.</p>'
>> );
>>
>>
>> Notes:
>> like to have defaults to the settings 99% of the users need.
>>
>> Link generation has as defaults (tslib_content)
>> intTarget =
>> extTarget = _top
>>
>> which can be leaved unchanged (IMHO)
>>
>> Steffen
>>
>>
>> --------------------------------------------------------------------------------
>>
>>
>>
>> begin 666 page_target_default_compat.diff
>> M26YD97 at Z('1Y<&\S+W-Y<V5X="]C<W-?<W1Y;&5D7V-O;G1E;G0O97AT7VQO
>> M8V%L8V]N9BYP:' -"CT]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
>> M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T-"BTM+2!T>7!O
>> M,R]S>7-E>'0O8W-S7W-T>6QE9%]C;VYT96YT+V5X=%]L;V-A;&-O;F8N<&AP
>> M"2AR979I<VEO;B R-C$Q*0T**RLK('1Y<&\S+W-Y<V5X="]C<W-?<W1Y;&5D
>> M7V-O;G1E;G0O97AT7VQO8V%L8V]N9BYP:' )*'=O<FMI;F<@8V]P>2D-"D! 
>> M("TR-"PV("LR-"PQ,"! 0 T*( D)"0D\;&D^/&(^0U-3(&)A<V5D(")I;6%G
>> M92(@86YD(")T97AT('=I=&@@:6UA9V4B/"]B/CQB<B O/D%S('1H92!E>'1E
>> M;G-I;VX at 8W)O;E]C<W-S='EL961I;6=T97AT(&AA<R!B965N(&UE<F=E9"!I
>> M;G1O('1H92!C;W)E+"!R96YD97)I;F<@;V8@=&AE(&-O;G1E;G0 at 96QE;65N
>> M=',@(FEM86=E(B!A;F0@(G1E>'0@=VET:"!I;6%G92(@:&%S(&)E96X at 8VAA
>> M;F=E9"!T;R!B92!#4U,@:6YS=&5A9"!O9B!T86)L92!B87-E9"X at 4F5A9"!T
>> M:&4@/&$@:')E9CTB:'1T<#HO+W=I:VDN='EP;S,N;W)G+VEN9&5X+G!H<"]4
>> M65!/,U\T+C B('1A<F=E=#TB7V)L86YK(CXT+C @<F5L96%S92!N;W1E<SPO
>> M83X at 9F]R(&9U<G1H97(@:6YF;W)M871I;VXN/"]L:3X\+W5L/B<L"B ))V1E
>> M<V-R:7!T:6]N7V%C:VYO=VQE9&=E)R ]/B G66]U('=I;&P@:&%V92!T;R!U
>> M<&1A=&4@>6]U<B!S='EL97-H965T<R!T;R!C;VUP;'D@=VET:"!T:&5S92!C
>> M:&%N9V5S+B<*("D["BLD5%E03S-?0T].1E]605)36R=30U]/4%1)3TY3)UU;
>> M)V5X="]I;G-T86QL)UU;)V-O;7!A=%]V97)S:6]N)UU;)W1X7V-S<W-T>6QE
>> M9&-O;G1E;G1?<&%G971A<F=E=',G72 ](&%R<F%Y* HK(" @("=T:71L92<@
>> M/3X@)T-34R!3='EL960 at 0V]N=&5N=#H at 1&5F875L="!T87)G971S(&9O<B!N
>> M;VXM9G)A;64@<&%G97,G+ HK(" @("=V97)S:6]N)R ]/B T,C P,# P+ HK
>> M(" @("=D97-C<FEP=&EO;B<@/3X@)SQP/E1H92!D969A=6QT('!A9V4@=&%R
>> M9V5T(&ES(&5M<'1Y("AS;R!N;R!T87)G970@:7, at 9V5N97)A=&5D*2X at 268@
>> M>6]U('5S92!F<F%M97,L('EO=2!H879E('1O('-E="!I="!T;R!P86=E(&EN
>> M($-O;G-T86YT<RX\+W ^)PHK*3L*( HM"B _/@T*7"!.;R!N97=L:6YE(&%T
>> M(&5N9"!O9B!F:6QE#0I);F1E>#H@='EP;S,O<WES97AT+V-S<U]S='EL961?
>> M8V]N=&5N="]S=&%T:6,O8V]N<W1A;G1S+G1X= T*/3T]/3T]/3T]/3T]/3T]
>> M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
>> M/3T]/3T]/0T*+2TM('1Y<&\S+W-Y<V5X="]C<W-?<W1Y;&5D7V-O;G1E;G0O
>> M<W1A=&EC+V-O;G-T86YT<RYT>'0)*')E=FES:6]N(#(V,3$I#0HK*RL@='EP
>> M;S,O<WES97AT+V-S<U]S='EL961?8V]N=&5N="]S=&%T:6,O8V]N<W1A;G1S
>> M+G1X= DH=V]R:VEN9R!C;W!Y*0T*0$ @+3DW+#8@*SDW+#$T($! #0H@(" C
>> M(&-A=#UA9'9A;F-E9"]L:6YK<SL@='EP93US;6%L;#L@;&%B96P](%1A<F=E
>> M="!F;W(@:6YT97)N86P@;&EN:W,Z(%-H;W5L9"!M871C:"!T:&4@;F%M92!O
>> M9B!T:&4 at 8V]N=&5N="!004=%+6]B:F5C="!I;B!4>7!O4V-R:7!T('=H96X@
>> M=7-E9"!W:71H(&9R86UE<RX at 36]S="!C87-E<SH at 4V5T('1O(")P86=E(B!I
>> M9B!Y;W4@:&%V92!F<F%M97,@:6X@=&AE('1E;7!L871E+B!)9B!N;W0L('-E
>> M="!T;R B(B H96UP='DI"B!004=%7U1!4D=%5" ]('!A9V4*( HK6V-O;7!A
>> M=%9E<G-I;VX@/2 T+C(N,%T**R @"BL@(", at 8V%T/6%D=F%N8V5D+VQI;FMS
>> M.R!T>7!E/7-M86QL.R!L86)E;#T at 5&%R9V5T(&9O<B!I;G1E<FYA;"!L:6YK
>> M<SH at 4VAO=6QD(&UA=&-H('1H92!N86UE(&]F('1H92!C;VYT96YT(%!!1T4M
>> M;V)J96-T(&EN(%1Y<&]38W)I<'0@=VAE;B!U<V5D('=I=&@@9G)A;65S+B!-
>> M;W-T(&-A<V5S.B!S970@=&\@(B(@*&5M<'1Y*2X at 268@>6]U(&AA=F4 at 9G)A
>> M;65S(&EN('1H92!T96UP;&%T92!S970@=&\@(G!A9V4B( HK4$%'15]405)'
>> M150@/0HK"BMC;VYT96YT+G!A9V5&<F%M94]B:B ^"BM;96YD70HK"B!;8V]M
>> M<&%T5F5R<VEO;B ](#,N.2XP70H@"B!S='EL97,N8V]N=&5N="YI;6=T97AT
>> M(#X*0$ @+3$T,RPU("LQ-3$L-"! 0 T*( H at 6T5.1%T*( HM(R!465!/,R!#
>> M5E, at 240Z("1)9"0*+0HK(R!465!/,R!#5E, at 240Z("1)9"0-"EP at 3F\@;F5W
>> M;&EN92!A="!E;F0@;V8 at 9FEL90T*26YD97 at Z('1Y<&\S+W-Y<V5X="]C<W-?
>> M<W1Y;&5D7V-O;G1E;G0O<W1A=&EC+W-E='5P+G1X= T*/3T]/3T]/3T]/3T]
>> M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
>> M/3T]/3T]/3T]/0T*+2TM('1Y<&\S+W-Y<V5X="]C<W-?<W1Y;&5D7V-O;G1E
>> M;G0O<W1A=&EC+W-E='5P+G1X= DH<F5V:7-I;VX@,C8Q,2D-"BLK*R!T>7!O
>> M,R]S>7-E>'0O8W-S7W-T>6QE9%]C;VYT96YT+W-T871I8R]S971U<"YT>'0)
>> M*'=O<FMI;F<@8V]P>2D-"D! ("TY.34L-R K.3DU+#$R($! #0H@"7T*('T*
>> M( HK6V-O;7!A=%9E<G-I;VX@/2 T+C(N,%T**W1T7V-O;G1E;G0N;65N=2XR
>> M,"YD969A=6QT+C$N=&%R9V5T(#T@>R1004=%7U1!4D=%5'T**W1T7V-O;G1E
>> M;G0N;65N=2XR,"XR+C$N=&%R9V5T(#T@>R1004=%7U1!4D=%5'T**UME;F1=
>> M"B **PH@(R J*BHJ*BHJ*BHJ*BHJ*BHJ"B C($-4>7!E.B!S:&]R=&-U= H@
>> M(R J*BHJ*BHJ*BHJ*BHJ*BHJ"D! ("TQ-#DY+#0@*S$U,#0L-"! 0 T*(%M%
>> M3D1="B *( HM(R!465!/,R!#5E, at 240Z("1)9"0**R, at 5%E03S, at 0U93($E$
>> E.B D260D#0I<($YO(&YE=VQI;F4 at 870@96YD(&]F(&9I;&4-"@``
>> `
>> end
>>
>> _______________________________________________
>> Before posting to this list, please have a look to the posting rules
>> on the following websites:
>>
>> http://typo3.org/teams/core/core-mailinglist-rules/
>> http://typo3.org/development/bug-fixing/diff-and-patch/ 
>> _______________________________________________
>> TYPO3-team-core mailing list
>> TYPO3-team-core at lists.netfielders.de
>> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-core 