[TYPO3-core] IRRE implementation bugs
Kasper Skårhøj (GMAIL)
kasper.typo3 at gmail.com
Sat Oct 20 01:14:08 CEST 2007
>
> Well, that's not quite true. When you look at moving or copying of
> records, IRRE children are always copied/moved along with the parent.
> (That is also why it's highly suggested to disable showing IRRE child
> tables in the list module.)
> So in those cases, they ARE treated as one object inside TYPO3s
> core as
> well.
OK, but thats a bit I don't get. Why shouldn't it be possible to
share a child between two records as we can with normal group fields?
In an implementation with these constraints, it has many implications
for the core parts elsewhere. What if I make a copy of a child? What
if I move it? What if I delete it? What if I link to it from another
record? Am I not then breaking the concept of "exclusive parenthood"?
I can understand that someone wishes to copy a parent and have the
children follow, but it shouldn't be a rule that it always should
happen like that. It should simply be a special implementation of a
copy command that does this automatically for people. For instance,
if you put to records to the clipboard and the one has a relation to
the other and make a copy of the clipboard, the relation is mapped.
The same for IRRE records; A copy command that wishes to copy the
"whole object" as seen from a certain application should traverse the
structure and issue a copy command on all elements in one sessions -
then tcemain takes care of the rest.
Actually I hope IRRE would work like this; That it could _also_ be
"just a clever way" because there will be applications where you
would like the nested form view but without the implications when you
make a copy or move the elements.
- kasper
>
>> If we wish to make them versioned all together we must invent a
>> meta-concept for grouping versions somehow. This could be useful
>> for other
>> things too, for instance someone wanted a new element verison of a
>> page to
>> trigger element versions of all content elements on the page -
>> well, ok, then
>> but we must invent a new meta-concept for this. So far my concerns
>> with IRRE in
>> general, forgive me if I am not right about the implementation,
>> after all I just
>> concluded from the core.
>
> Yes, maybe that'd be something to think about.
>
> Now regarding the specific bug you found:
>
>> [...]
>>
>> Ergo, we select directly from offline records which is by
>> definition forbidden.
>> The right way is to first select the live record, then look for an
>> overlay record.
>>
>> I can't say exactly what the wanted effect for IRRE shoudl be but
>> definitely
>> this is wrong and gotta be a bug lots of people are having with
>> workspaces now.
>
> OK. If that's so, I agree that you are the one who decides what's
> wrong
> or right regarding workspaces and therefore am fine with you reverting
> Dmitry's change.
>
>> Conclusions:
>> - Remember, since August I'm the authority on versioning and
>> workspaces and I
>> must approve any non-trivial change to these parts. This is to
>> avoid these
>> situations because we have realized that the core team as a unit
>> doesn't
>> understand this technology well enough to maintain it error-free.
>
> I didn't notice when that decision was made, but agree that it's
> sensbile.
>
>> - Question: Are you sure IRRE is conceptually sound? Did any of my
>> concerns ring
>> true?
>
> Regarding workspaces the answer is definitely No, but apart from that,
> I'd say yes, but it works differently to how you think it works.
> IRRE is
> not only "just a clever way interface". Inside TYPO3s core a record
> and
> its children IS treated as one object when copying and moving. That
> needs to be considered when thinking about possiblities of IRRE
> versioning as well.
>
>> - I will revert this code issue
>
> Yep, fine with me.
>
> cheers
> Ingmar
> _______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
>
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/
> _______________________________________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.netfielders.de
> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-core
- kasper
-----------------------------------------------------
How many women does it take to get a baby in 1 month?
Kasper Skårhøj
Tryggevældevej 8
2720 Vanløse
+45 20 999 115
skype : kasperskaarhoej
- kasper
-----------------------------------------------------
How many women does it take to get a baby in 1 month?
Kasper Skårhøj
Tryggevældevej 8
2720 Vanløse
+45 20 999 115
skype : kasperskaarhoej
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20071020/bf971783/attachment.htm
More information about the TYPO3-team-core
mailing list