[TYPO3-core] RFC: Bugfix/Feature #5779

[Bernhard Kraft]

Ingo Renner wrote:
> Bernhard Kraft wrote:
> 
>> see attached patch.
> 
> works so far. A few comments though:
> 
> * what about that commented line 17 in your patch

This and the question of Oliver:
--------
Just a question: The file listing in the TYPO3 Element Browser
(typo3/class.browse_links.php) doesn't use the fileIgnore setting, does
it? If not, could you please add the fileIgnore filter also to the
Element Browser? Thanks in advance!
-------

... get solve by removing the comment marks. Sorry ... I tested if 
everything works as before when having the old code - and tested the new 
line. If the comment "//" get's removed then also files/dirs in the 
element browser get hidden (t3lib_div::getFilesInDir)


> * please make patches start in the TYPO3 source root directory

sorry. until now I always did:

diff -ru TYPO3core.org TYPO3core.modified

this results in a diff file you can apply with

patch -p 1 < patchfile.diff

when you are inside the source-dir you are going to modify.

This is how stucki told me years ago how to make patches - i guess it 
was during the zapping session.

Question: shall I make the diff from within the original source or from 
within the modified ...


> * are you sure you got all paces covered where dot files might be visible?

Well: currently I got:

* Fileadmin (dirs and files)
* Element Browser (dirs and files)

Hiding .svn files and similar in the extension-manager has been taken 
care of by someone else (i didn't look it up in the changelogs/svn 
changes on sourceforge)

If we find a place where it is missing later on I will add it therer ...

In my opinion it is not a good idea to instantly put it everywhere where 
a directory or file is read.

> * please rename the funtion to ignoreFile()

Why ? I see no reason for that ... if it is your wish I will do so ... 
but is there any explicit sense in that ?

> +0,5, the rest after good answers and changes ;-)

waiting for reply :)


greets,
Bernhard