[TYPO3-core] RFC: Hook request for t3lib_befunc + t3lib_userauthgroup

[Oliver Hader]

Hi Bernhard,

Bernhard Kraft schrieb:
> Hi Oliver and the others,
> Oliver Hader wrote:
> 
>> Seems like it happend again that we've done similar work... ;-)
>> See here: http://bugs.typo3.org/view.php?id=5613
>>
>> My patch there is extending the t3lib_matchcondition instead of creating
>> a new file. Maybe we could compare and merge some work if required.
> 
> We discussed this via Skype and I created a patch containing the
> "best of both worlds" :) ...
> 
> I integrated Olivers "hybrid" t3lib_matchcondition.php + supporting methods
> into the patch created by my - which does proper caching. Additionally the
> tsconfig-conditions have to get enabled via install-tool (As those require
> ts-matching for ever BE page hit. So enabling them by default would be a
> drawback in speed)
> 
> see attached diff or last file on:
> http://bugs.typo3.org/view.php?id=5613
> 
> PS: I also changed those "while (list=each)" statements in
> t3lib_matchcondition
> into "foreach" loops (this was already discussed some times)
> 
> PPS: Trunk only is ok for me and I guess also for Oliver.

Yepp, trunk only is the only way... ;)

Some annotations:

1) t3lib_TSparser_TSconfig
Why are you looking for $TSFE->sys_page? The hash-string stays the same
if deliverd to t3lib_pageSelect ($TSFE->sys_page) or to t3lib_BEfunc.
IMO we could replace the stuff in t3lib_TSparser_TSconfig::getHash() by:
  if (TYPO3_MODE=='BE' || isset($GLOBALS['TSFE']) &&
      is_object($GLOBALS['TSFE']) && $GLOBALS['TSFE']->beUserLogin) {
			return t3lib_BEfunc::getHash($hash, $expTime);
  }
Can't we?

2) t3lib_matchCondition::evalPageId
Something goes wrong here when working with the table 'pages', I have to
dig deeper here.

3) We have to encapsulate the new functions (private, protected, ...)


olly
-- 
Oliver Hader
http://inpublica.de/