[TYPO3-core] RFC: #6825: TCEforms -- Icon for empty palettes should not be displayed

[Ingo Renner]

Martin Kutschker wrote:
> Ingo Renner schrieb:
>> Benjamin Mack wrote:
>>> sorry, I will add the "public" before commiting, is that okay?
>>
>> sure!
> 
> Question: do we need a public declaration? I see a point in adding 
> private/protected only to new functions but we could easily add public 
> to all functions and change var to public as well.

sure just go ahead!
We might still ned to discuss though whether we make stuff private that 
was marked as such...

> The only thing we must also do is to move the PHP version check to the 
> top of typo3/init.php and of typo3/sysext/cms/tslib/index_ts.php. The 
> reason is that older versions of PHP would have troubles with the new 
> declarations.

no need for that, with these keywords you won't be able to run TYPO3 4.2 
on PHP4 anyways. PHP4 doesn't now these declarations and thus throws a 
fatal error because of an unexpected string (or so) and stops executing 
the script.

> If we do that we can also make all t3lib_div and t3lib_BEfunc functions 
> static.

sure!


good idea
Ingo

-- 
Ingo Renner
TYPO3 Core Developer, Release Manager TYPO3 4.2