[TYPO3-core] RFC: bugfix #6240, pageNotFound_handling returns empty page if specified URL cannot be retrieved

[Ernesto Baschny [cron IT]]

Hi,

+1 to the nobrainer for 4.1 and trunk, since it will get back the
behaviour we used to have. Based on reviewing only.

In trunk we should at least send a warning to the sysLog when we hit
this case. But I agree with Masi that a more general approach is needed,
so these errors can be handled in a generic way (maybe by providing a
nice "fallback" that looks ok for a regular user and also provides a
hint to the admin where he has to look for the reason = sysLog).

Cheers,
Ernesto

Helmut Hummel wrote: on 16.11.2007 14:17:

> Type: Bugfix
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=6240
> 
> Branches:
> TYPO3_4-1, trunk
> 
> Problem:
> When using $TYPO3_CONF_VARS['FE']['pageNotFound_handling'] with a URL,
> which cannot be retrieved with getURL, a blank page is shown instead of
> a meaningful error message.
> 
> Solution:
> 1. Fix the check of the return value of the getURL function (which was
>    introduced here: [1])
> 2. Introduce a error message, that the specified URL cannot be
>    retrieved, instead of setting a location header and try to redirect
>    to the specified URL
> 
> Comment:
> I added bug_6240_nobrainer.diff for your information, and because it's
> the main part but I really would like to see the error message, too,
> because it makes no sense to redirect, if getting URL fails.
> 
> Perhaps bug_6240_nobrainer.diff can go into 4_1 and the other one in
> trunk only (since it changes behaviour).
> 
> Regards Helmut
> 
> [1]http://typo3.svn.sourceforge.net/viewvc/typo3/TYPO3core/trunk/typo3/sysext/cms/tslib/class.tslib_fe.php?r1=1770&r2=1798
>