[TYPO3-core] RFC: Feature #6442: Hook in browse_links request (for linking to records)

[Ingo Renner]

Daniel Pötzinger wrote:

> Thanks for improving the patch - I like the interface idea!

cool

> * I attached the complete file instead of a patch here, cause its not in 
> my svn control and was faster this way.
> 
> * the init function needs no additionalParameters - any reason why you 
> added this?

just in case for the future, this way we can add any parameters if we 
need to without having to alter the interface.

> 2) browse_links.php
> 
> *hookObject needs to be protected instead of private cause the inherited 
> classes needs it also.

fine with me. A comment: IMO we should try to introduce things as 
private and only switch to protected if someone needs it. OTOH one could 
also introduce getter/setters...

> 3) Whats with RTE linkbrowser? Would be perfect to have it also patched 
> in SVN cause without that its only a half solution.

??? where?


Ingo

-- 
Ingo Renner
TYPO3 Core Developer, Release Manager TYPO3 4.2