[TYPO3-core] RFC: #6259 Disabling Tabs with no fields (does not work)

[Benjamin Mack]

Hey Malte,

you don't need to post the full files or explain the changes you made. 
In my eyes this is just extra work, and we all know that time is 
precious and little for us.
Every developer should be able to read code and if he/she knows the 
codebase well enough, knows what you have changed.

Thanks for your work, Malte!

greetings,
benni.
-SDG-

www.xnos.de // www.xnos.org


Malte Jansen wrote:
> Hi Tapio,
> 
> Here is the list of changes:
> 
> t3lib/class.t3lib_tceforms.php
> ~ Lines 644ff; near the end of getMainFields(...)
> 1. Removed the if-condition.
> 2. Added if-condition for table-wrapping the $sContent if not empty
> 3. Removed table-wrapping in $parts[$idx] = array(...
> 
> => Only table-wrapping, when there is any field rendered
> 
> 
> typo3/template.php
> ~ Lines 1429 ff ( getDynTabMenu(...) )
> 1. Removed if-Condition with closing breaket:
>                 if ($isActive) {
> => All other things are already implementet
> 
> 
> ~ Lines 1550 ( getDynTabMenuJScode() -> jsfunction DTM_activate(...)
> 1. Adding if-Condition for following line
>                              
> document.getElementById(DTM_array[idBase][cnt]+"-MENU").attributes.getNamedItem("class").nodeValue 
> = "tab";
> 
> => Otherwise the disabled-class is overwritten with the tab-class
> 
> 
> typo3/sysext/t3skin/stylesheets/typo3-dyntabmenu.css
> - should be clear, only some small layout modfications
> 
> 
> I hope this will help you for checking the patch.
> 
> I have used the newest from the trunk. Be aware that there is an other 
> new patch applied to the trunk which adds the function "newline  for 
> tabs" in tce_forms, so there is newline in $parts[$idx] = array(....
> 
> 
> Cheers,
> 
> Malte
> 
> 
> 
> Tapio Markula schrieb:
>> Malte Jansen kirjoitti:
>>> Hi,
>>>
>>> here is a new Version of the patch, because one part of the 
>>> template.php has moved over 300 lines and one part was modified (see 
>>> [TYPO3-core] RFC: #6256 $TCA: Newline for Tabs (--div--))
>>>
>>> Cheers,
>>>
>>> Malte
>>>
>>> Dmitry Dulepov [typo3] schrieb:
>>>> Hi!
>>>>
>>>> Malte Jansen wrote:
>>>>> Problem:
>>>>> Disabling Tabs with no fields does not work
>>>>> because the check (in template.php) is never true, because the 
>>>>> parameter is never empty because of a table-wrap in the 
>>>>> class.t3lib_tceforms.php
>>>>>
>>>>> Solution:
>>>>> The table-wrap should only be done, when there is somesthing to wrap.
>>>>> (See Bug)
>>>>
>>>> +1 for this patch. Tested, works great. Anyone else to review it?..
>>>>
>>>
>>
>>
>> The problem for me to test is that is is patch for previous patch.
>> I would try it in frontend and I should make changes manually.
>> Difficult to figure, what should change.
>>
>> Could you send complete functions in txt-file.
>> I could add fix also to frontend editing using Forms on page
>> - I have added into pixe_feediting tabs for frontend.
>> That could then propose also for core.
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
> 
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/ 
> _______________________________________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.netfielders.de
> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-core