[TYPO3-core] RFC: #6259 Disabling Tabs with no fields (does not work)

[Malte Jansen]

Hi Tapio,

Here is the list of changes:

t3lib/class.t3lib_tceforms.php
~ Lines 644ff; near the end of getMainFields(...)
1. Removed the if-condition.
2. Added if-condition for table-wrapping the $sContent if not empty
3. Removed table-wrapping in $parts[$idx] = array(...

=> Only table-wrapping, when there is any field rendered


typo3/template.php
~ Lines 1429 ff ( getDynTabMenu(...) )
1. Removed if-Condition with closing breaket:
				if ($isActive) {
=> All other things are already implementet


~ Lines 1550 ( getDynTabMenuJScode() -> jsfunction DTM_activate(...)
1. Adding if-Condition for following line
							 
document.getElementById(DTM_array[idBase][cnt]+"-MENU").attributes.getNamedItem("class").nodeValue 
= "tab";

=> Otherwise the disabled-class is overwritten with the tab-class


typo3/sysext/t3skin/stylesheets/typo3-dyntabmenu.css
- should be clear, only some small layout modfications


I hope this will help you for checking the patch.

I have used the newest from the trunk. Be aware that there is an other 
new patch applied to the trunk which adds the function "newline  for 
tabs" in tce_forms, so there is newline in $parts[$idx] = array(....


Cheers,

Malte



Tapio Markula schrieb:
> Malte Jansen kirjoitti:
>> Hi,
>>
>> here is a new Version of the patch, because one part of the 
>> template.php has moved over 300 lines and one part was modified (see 
>> [TYPO3-core] RFC: #6256 $TCA: Newline for Tabs (--div--))
>>
>> Cheers,
>>
>> Malte
>>
>> Dmitry Dulepov [typo3] schrieb:
>>> Hi!
>>>
>>> Malte Jansen wrote:
>>>> Problem:
>>>> Disabling Tabs with no fields does not work
>>>> because the check (in template.php) is never true, because the 
>>>> parameter is never empty because of a table-wrap in the 
>>>> class.t3lib_tceforms.php
>>>>
>>>> Solution:
>>>> The table-wrap should only be done, when there is somesthing to wrap.
>>>> (See Bug)
>>>
>>> +1 for this patch. Tested, works great. Anyone else to review it?..
>>>
>>
> 
> 
> The problem for me to test is that is is patch for previous patch.
> I would try it in frontend and I should make changes manually.
> Difficult to figure, what should change.
> 
> Could you send complete functions in txt-file.
> I could add fix also to frontend editing using Forms on page
> - I have added into pixe_feediting tabs for frontend.
> That could then propose also for core.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: typo3-dyntabmenu.css
Type: text/css
Size: 859 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20071112/fdb1df1d/attachment-0001.css 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: disable_empty_tabs_changedfunctions.txt
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20071112/fdb1df1d/attachment-0001.txt