[TYPO3-core] RFC: Bug #529: update inline TypoScript help

Sebastian Kurfuerst sebastian at typo3.org
Mon Nov 12 23:01:49 CET 2007


Hi,
I forgot to add Ingmar's comments as well:
Greets, Sebastian


Hi Francois,

here are some comments:
- there was a major bummer in the rebuild part: Even if you didn't click
the rebuild button the following was always executed:
	// remove all data from the database

case 2:
	$this->purgeSQLContents();
which always emptied the table if you hit case 2 from the function menu.

- Correct the comment, and use t3lib_div::makeInstance() here:
+			// we use a pure PHP unzip
+		$unzip = new em_unzip($file);


- The module currently has $MCONF['access']='user,group';, which is
  good. But I think the rebuild functions should be limited to admins.

- typo3temp/zip_temp/ should be changed to
  typo3temp/tx_tsconfighelp_ziptemp/

- create the patch from the TYPO3 root dir next time, please

- Is there an icon for the module? If so, please attach it to your mail.

Thanks a lot for your work!

cheers
Ingmar



More information about the TYPO3-team-core mailing list