[TYPO3-core] RFC: Bug #6456: IRRE - Palettes are not rendered correctly on nesting records using the same table

[Oliver Hader]

Hi Masi,

Martin Kutschker schrieb:
> Oliver Hader schrieb:
>> Martin Kutschker schrieb:
>>> Ingmar Schlecht schrieb:
>>>> You mean $tceforms->palettesRendered is a private class variable,
>>>> right?
>>> No (couldn't be in PHP4)
>>>
>>>> Well, I think it should just be mentioned in a comment close to the
>>>> declaration of var $palettesRendered that it's accessed from IRRE and
>>>> therefore kind of public.
>>> Why has every property or method to be public (in a broad sense, not
>>> stricly OO speak). I think that our problem with "compatibility" is that
>>> every tiny peace of code is "part of the API" and therefore unchangable.
>>>
>>> We should really try to add new stuff as private/protected in 4.2 and
>>> think twice befor we change it to public.
>>
>> So, you're talking about the new method in t3lib_TCEforms_inline which
>> should be private/protected for the Trunk version?
> 
> I think it would be nice if we started to add things as protected
> (private will break XCLASSing) until there is a good reason to make
> stuff public.

You're right. I'll commit the patch for Trunk with the protected method
tomorrow.


olly
-- 
Oliver Hader
http://inpublica.de/