[TYPO3-core] RFC: Bug 5602: spamProtectEmailAddresses_atSubst is not recognized correctly

[Franz Holzinger]

Hello Oliver, 

> 
> The scenario before was the same (at-substitution outside the mentioned
> IF statement). This means if only spamProtectEmailAddresses is set, the
> "@" is replaced with "(at)" by default, even if the property
> spamProtectEmailAddresses_atSubst is not set (you can test this with the
> latest release of the 4.0.x branch). 
> 
> Have a look to the TSref were this default value is also mentioned:
> http://typo3.org/documentation/document-library/references/doc_core_tsref/4.1.0/view/7/3/ 
> 
But here a case is mentioned, when all characters are changed into Unicode 

mailto:a at b.c will be converted to
mailto:a@b.c 

So the new code line
$spamProtectedMailAddress = str_replace('@', ($atLabel ? $atLabel : '(at)'), 
$mailAddress); 

needs only be done in the ELSE block of this IF: 

if ($GLOBALS['TSFE']->spamProtectEmailAddresses === 'ascii') 

And IMHO even more lines doing replacements should go there. 

 - Franz