[TYPO3-core] RFC: fix IRRE in workspaces

Michael Stucki michael at typo3.org
Tue May 1 17:24:32 CEST 2007

Hi Masi,

> > => $updateToUid is never >0 when it is not an integer value!
> The original code had the ! around the whole expression:
> !(a && b).
> After the change it's (!a && b), which is not the same.

Yes, that's why I mentioned it :-)

> I guess this was just a slip. But isn't it better to do argument checks
> (aka asserts) right at the beginning of a function? I guess it doesn't
> make much sense if $parentUid and $updateToUid are not integers.

Make sense when writing new code, but leads to difficulty while making a 
cleanup... So you should just do it the way you prefer...

- michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20070501/7ad227a5/attachment.pgp 

More information about the TYPO3-team-core mailing list