[TYPO3-core] RFC: unzip_path in Ext.Manager

Michael Stucki michael at typo3.org
Tue Jan 23 12:09:08 CET 2007


Hi Ernesto,

old mail...

>> -1 since we "fixed" many installations by changing this path already ;-)
> 
> But then t3lib_extfilefunc::func_unzip doesn't work anymore. Well, might
> not be so dramatic, as this doesn't seem to be used anywhere anyway.

This makes me wonder why the EM provides its own unzip class when the
fuctionality would fit better at this place?

>> Could you please add a check if "unzip" is part of the string?
>> BTW, don't forget to add ".exe" on Windows systems...
> 
> That would do the same as t3lib_exec::getCommand is already doing. I
> think this is a bit ugly to do it in more than one place. So I propose:
> 
> 1) I add a "special handling" of the unzip path to
> t3lib_exec::_getConfiguredApps. This would consider BE/unzip_path and
> check if its a full path to or of the binary and set acordingly in the
> array.
> 2) Then I just use t3lib_exec::getCommand in all places where unzip is
> needed.
> 3) We mark/set BE/unzip_path as "deprecated" so it can later be removed
> from the configuration view.

Good idea, +1!

Will you write this change?

> This would handle both cases and we can then later drop support for
> BE/unzip_path and go straight to SYS/binSetup without any addition of
> the code.
> 
> Right?

Yes :-)

- michael
-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/


More information about the TYPO3-team-core mailing list