[TYPO3-core] RFC: Bug 4957: CSV export stop exporting a field when there is a linebreak

[Oliver Hader]

Hi Thomas,

Thomas Hempel wrote:
>> Solution:
>> Line-breaks are allow in CSV files. Thus the restriction to use only the
>> first line was removed from t3lib_div::csvValues.
> The patch looks good to me so far after reading.
> But wouldn't it a good idea to add a check if $row is really an array?
> I'm not sure if this is checked somewhere before or if $row is an array
> in any case. Anyway if it is not, PHP will throw an ugly error. I'm not
> sure what default procedure for such things is in the core.

You're absolutely right. I just added an "is_array" check and attached
the updated patch files (with and without whitespace changes).


olly
-- 
Oliver Hader
http://inpublica.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004957_v3_nows.patch
Type: text/x-diff
Size: 729 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20070224/96ddc357/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004957_v3.patch
Type: text/x-diff
Size: 826 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20070224/96ddc357/attachment-0001.bin