[TYPO3-core] RFC: Bug #4951: SQL error when editing BE User

[Thomas Hempel]

Hi Michael,

>> I can't reproduce the error due to my mySQL version.
>> Anyway, I'm not sure about the patch. I'm not too much inside WS and
>> versioning but do you think it's a good idea to make the PK a signed int?
>> If there are no complains about it, it's okay for me.
> 
> I'm not changing any keys! Just changing queries like this:
> 
> ... WHERE pid in (-1,1,2,3,525,623)
> 
> into this:
> 
> ... WHERE pid in (1,2,3,525,623)
Yeah I know. I was unsure if the change of the SQL file should be part of the patch. But as it was 
not attached I think I can forget about it. ;-)

> The pidList comes from outside, so it must apply for all tables, versioned and 
> not versioned ones. I see no other solution to that problem.
Yes ok. But as far as I can see. The lostRecord method is called on only two places in the core. 
Only on of them adds "-1,0," at the beginning (typo3/sysext/lowlevel/dbint/index.php - line 456 
(http://www.typo3-unleashed.net/typo3api_41b3/html/typo3_2sysext_2lowlevel_2dbint_2index_8php-source.html#l00409)).

All I want mention is, that it would make more sense in my opinion to avoid the -1 at this place and 
  not with a regex afterwards.

If it doesn't work out or if I'm wrong, your solution is ok for me and I give it a +1. :-)
Unfortunately I can't check it because the methods are never called here. Maybe I have not the right 
circumstances to reproduce.


Greets,
Thomas


-- 
typo3-unleashed.net