[TYPO3-core] RFC: Improvment #6670: Enable Tabs in Page Properties II

[Oliver Hader]

Hi Steffen,

Steffen Kamper schrieb:
> "Oliver Hader" <oh at inpublica.de> schrieb im Newsbeitrag 
> news:mailman.1.1197574917.23769.typo3-team-core at lists.netfielders.de...
>> Hi Malte,
>>
>> Malte Jansen schrieb:
>>> This is an SVN patch further development.
>>>
>>> Type: Feature improment
>>>
>>> Bugtracker references:
>>> http://bugs.typo3.org/view.php?id=6670
>>>
>>> Branches:
>>> Trunk
>>>
>>> Problem:
>>> Some unclear meanings and improvments from the HCI-list
>>>
>>>
>>> Solution:
>>> Note: if a palette has a title it is always shown!
>> The field "fe_login_mode" is changed from the values "1" (disabled) and
>> "2" (enabled) to a simple check box. For usability this is fine, but
>> there must be a handling to convert the old data "{1;2}" to "{0;1}".
>>
> 
> there is no need for that, because core does not difference, the check is 
> only in tslib_fe:
> 
> $disable = (int)$this->rootLine[$a]['fe_login_mode'] === 1 ? TRUE : FALSE;
> 
> so value of 2 doesn't affect (same as 0)

Additionally the label of that field has to be changed to "Enable FE
Login" or to "Disable FE Login". Let's assume this field is called
"disable" in future, thus a value of "1" means "Disable FE Login".

Now imagine a page record that has this field set to "2" (which meant
"Enable FE Login"). Now the patch is applied and a BE user modifies some
fields of that page record but doesn't change the "fe_login_mode" field.
This field will now be stored as "1" to the database which means now
"Disable FE Login".

This shows, that this has of course to be handled by an update wizard or
whatever. Furthermore, as Masi wrote, this has to be marked with "!!!"
in the ChangeLog and NEWS.txt.

olly
-- 
Oliver Hader
http://inpublica.de/