[TYPO3-core] RFC: faster t3lib_div::inList

Franz Holzinger franz at fholzinger.com
Sat Aug 18 16:23:42 CEST 2007


This is a SVN patch request. 

Type: Code cleanup 

Description:
The t3lib_div::inList uses strstr inside. This is not recommended under 
http://php.net
Note:  If you only want to determine if a particular needle  occurs within 
haystack, use the faster and less memory intensive function strpos() 
instead. 

Branches: Trunk 

Replace the strstr with the faster strpos function. 

Question:
Would it make it easier for coding if even spaces would be allowed in this 
function betwenn the items and the commas ',' ? The description of the 
function does not tell that blanks are not allowed at the moment. 

If you agree I would enhance the patch for this. 

 - Franz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: inList.diff
Type: text/x-patch
Size: 434 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20070818/642f8175/attachment.bin 


More information about the TYPO3-team-core mailing list