[TYPO3-core] RFC: Various admin panel improvements
michael at typo3.org
Fri Aug 10 23:56:03 CEST 2007
thanks a lot to you and everybody else who reviewed this patch! I have now
committed it, here are some comments:
>>> I'm not sure if it is necesarry but you used "font-family:verdana".
>>> Shouldn't we use "font-family:verdana,sans-serif" for those who don't
>>> have verdana installed!?
>> Good. I even think I remember having the adminPanel seen with a serif
>> font, probably due to this... I changed that patch now accordingly.
> Maybe "font-family: Verdana, Arial, Helvetica, sans-serif" or something
> like this could be used here, like also Thomas suggested.
I used this string for all font-family definitions now.
> Maybe it's possible to avoid the additional preg_replace() in line 186
> of your patch by a simple substr or in combination with the
> preg_match_all() before in line 184 of your patch. I didn't investigate
> further, but think this could work.
I didn't touch this now, but will do later.
> In line 577 of your patch is an old code part commented out which could
> be removed.
> After all I was able to reproduce the behaviour of the admin panel and
> can confirm that your patch solves this issue. Maybe it's also possible
> to simplify the preg_match_all/preg_replace as mentioned above.
> In general +1 from my side
Thanks! Committed to Trunk now.
Use a newsreader! Check out
More information about the TYPO3-team-core