[TYPO3-core] OT: TRUE vs. true (was: Re: RFC: #4155 / userFunc in conditions / t3lib_div::callUserFunction)

[Michael Stucki]

Hi Dmitry,

> Wolfgang Klinger wrote:
>>  No problem with me, in fact I only did this because it was part of
>>  Michael's last cleaning patch and I thought why not doing it here too
>>  (though I like 'true' better than 'TRUE', but anyway, I'll stick to
>>  what's common here)
> 
> I also write "true". Our CGL doc does not define how it should be (and I
> do not think it should!).

TRUE is not just a string, it is a constant defined somewhere at the very
beginning of the PHP parser.

I think that TRUE points out that this is a constant, though they also might
be lowercase of course.

There is one exception where I think you should not change the case:

There are two comments in class.t3lib_matchcondition.php in your patch:

+ break;        // only TRUE AND TRUE = TRUE, so we have to break here

Same for OR: I suggest to keep it lowercase here because this makes it
easier to read the highlighted AND/OR.

For the rest, do what you prefer :-)

- michael
-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/