[TYPO3-core] t3lib_BEfunc::getProcessedValue hook fixes
Martin Kutschker
Martin.Kutschker at n0spam-blackbox.net
Mon Nov 13 10:28:35 CET 2006
Bernhard Kraft schrieb:
>
>> Is there a special reason why all paramaters are passed as references?
>> I'm all for references when passing object, arrays and huge strings
>> but here it simply doesn't look in sync with comparable existing code.
>
> The reason behind this is: To make them modifiable out of the hook. If you
> want to change any of the values from your hook method you can do this now.
Hm. I'll have a look and see if I really want that. Changing parameters
like "table" seems highly dubious.
> Another thing is that as last parameter the $this value is passed - I do
> not know who introduced this hook - but the probably didn't take in the fact
> that t3lib_BEfunc is never(?) called as object but only directly using the scope
> (::) operator ...
Well, the API requires an object. But if the functions is static it should
of course be a dummy var.
> Is there any objection in passing the parameters as reference ?
>>> Of course we have to add this option to T3-Core-Api doc ... i will
>>> write a text if the patch get's accepted.
>>
>> Michael won't like this.
>
> Why is this a problem ?
He wants documentation up front as guys like me (shame, shame, shame) are
likely to forget to deliver them after a commit.
Masi
More information about the TYPO3-team-core
mailing list