[TYPO3-core] RFC: GIFBUILDER transparency

[Martin Kutschker]

Bernhard Kraft <kraftb at kraftb.at> writes on 
Fri, 17 Mar 2006 18:41:12 +0100 (MET):

> Franz Holzinger wrote:
> 
> >>- $retCol = false;
> >>+ $retCol = -1;
> > 
> > 
> > You have changed the interface here. This can be a break in
> > compatibility for extensions using unifyColors.
> This method was newly introduced with my GIFBUILDER patch.


And if even not. Was it a public method? Internal methods are IMHO subject to change without notice. Otherwiese we couldn't change anything.


> I had to set it to -1 because else the method would return two
> different kind of values (integer for color index boolean false for
> not found).


PHPs search functions do it the same. FALSE means not found, an integer returns the "real thing". Anyway, I don't care if it's -1 or FALSE.

Masi