[TYPO3-core] RFC: Indexed Search template fixes

[Michael Stucki]

Hi Rupi,

finally I have changed the template according to your comments (+some more
minor things).

Attached are three patches:
indexed_search_browseList_post_v1.diff contains only the new changes
compared to my last patch version.

indexed_search_browseList_v3.diff contains the new complete changeset.

indexed_search_browseList_v3_w.diff is the complete changeset with
whitespaces ignored.

- michael

rupert germann wrote:

> On Tuesday 28 February 2006 14:29, Michael Stucki wrote:
>> Attached is a new version. I've hugely changed the whole default
>> template:
> 
> since there are tags like <br /> in the html template, I think we want to
> make this at least XHTML transitional by default.
> then things like:
> 
> <form action="###ACTION_URL###" method="POST" name="tx_indexedsearch">
> 
> are not valid (should be "post" in lowercase).
> other html parts the validator complains about:
> 
> <input type="text" name="tx_indexedsearch[sword]"
> value="###SWORD_VALUE###" class="tx-indexedsearch-searchbox-sword">
> (missing trailiung slash)
> 
> <input type="checkbox" value="1" name="tx_indexedsearch[extResume]"
> CHECKED> (missing trailing slash and shorttag (line 1398 in
> class.tx_indexedsearch.php))
> 
> shorttag "selected" in function renderSelectBoxValues
> 
> and at the end of the html template there are some <br/> tags with missing
> space in front of the slash
> 
> greets
> rupert
> 
> 
> 
> 
> 
> 
>>
>> - Dropped template_traditional.tmpl so there is only one template
>> anymore. Reason: both templates where very very similar, and I've seen no
>> more reasons to keep both. I know that it was me who once asked the
>> author of the template patch to write such a 2nd template, but to me it
>> seems that template_css.tmpl is also compatible with pre-4.0 layouts. I
>> will rename template_css.tmpl to template.tmpl before committing!
>>
>> - Changed the _CSS_DEFAULT_STYLE, removed obsolete classes, cleanup
>>
>> - Added a <div> layer around every main section of the template:
>>   - tx-indexedsearch-searchbox
>>   - tx-indexedsearch-rules
>>   - tx-indexedsearch-sec
>>   - tx-indexedsearch-secHead
>>   - tx-indexedsearch-res
>>
>> - Added alternative class names where it seems to make sense. Example:
>>   tx-indexedsearch-title => Added "title" to the class tag
>>
>>   => Question: Does it make sense to drop the old (long) class names?
>>
>> - Changed all nowrap to nowrap="nowrap"
>>
>> - Moved the <br /> from before each result to _after_ each result
>> (affects the 1st hit only)
>>
>>
>> Additionally, these changes were already posted yesterday:
>> - The result browser now uses unordered lists instead of a table
>> - Replaced the class "browsebox-SCell" with "browselist-currentPage"
>> - Changed <span class="browsebox-strong"> to <strong>
>> - Adding "summary" attributes to all tables (required for W3C validation)
>> - Fixed a bug: colspan=2" instead of colspan="2"
>>
>> Michael
>>
>> Michael Stucki wrote:
>> > This is a CVS patch request.
>> >
>> > Copy goes to Ben, please have a look at my changes to make sure we
>> > don't fix the same issues...
>> >
>> > Here are some last-minute fixes for the new indexed_search templates:
>> >
>> > - The result browser now uses unordered lists instead of a table
>> > - Replaced the class "browsebox-SCell" with "browselist-currentPage"
>> > - Changed <span class="browsebox-strong"> to <strong>
>> > - Adding "summary" attributes to all tables (required for W3C
>> > validation) - Fixed a bug: colspan=2" instead of colspan="2"
>> >
>> > Questions:
>> > - It seems strange unlikely that the closing tag of browsebox-strong is
>> > written inside the translation label. Since I've changed it from
>> > "</span>" to "###TAG_END###", I wonder wether the translators will
>> > notice this change or if I have to use a new label instead?!
>> >
>> > - I must admit that I've never used the *_editorcfg.txt files so far,
>> > so I'm not sure if these changes are correct. Is anybody using this
>> > after all?
>> >
>> > Regards, michael

-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: indexed_search_browseList_post_v1.diff
Type: text/x-diff
Size: 5560 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20060306/27bdd1f8/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: indexed_search_browseList_v3.diff
Type: text/x-diff
Size: 25669 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20060306/27bdd1f8/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: indexed_search_browseList_v3_w.diff
Type: text/x-diff
Size: 24524 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20060306/27bdd1f8/attachment-0002.bin