[TYPO3-core] RFC: Patch t3lib_page to make enableFields work better with DBAL

[Ernesto Baschny [cron IT]]

Karsten Dambekalns schrieb am 28.06.2006 19:02:

> Type: bugfix
> Branches: HEAD, TYPO3_4-0
> 
> In t3lib_pageSelect is a method named getMultipleGroupsWhereClause() that 
> needs to check for IS NULL (as already explained along some of my patches 
> from yesterday). The patch adds this.

+1

> Additionally the patch changes enableFields() to call that method with $this-> 
> instead of ::. I did this fix in an XCLASS first, where this was needed, if 
> getMultipleGroupsWhereClause() is patched directly this isn't strictly 
> needed - so please check if it causes any trouble. IMHO there should always 
> be an object instance if this code is used.

+1 for the changes, but as Masi already noted: in
t3lib/class.t3lib_tsfebeuserauth.php there is such a call:

	t3lib_pageSelect::enableFields($table,'',$ignore),

This will call enableFields without setting $this, which will break when
it hits the call to $this->getMultipleGroupsWhereClause().

Cheers,
Ernesto