[TYPO3-core] RFC: Fix bug when comparing version numbers

Franz Holzinger franz at fholzinger.com
Thu Jul 13 18:07:38 CEST 2006


Hello Karsten,

>On Wednesday 12 July 2006 20:41, Franz Holzinger wrote:
>  
>
>>I think this will not work in all cases.
>>    
>>
> ...
>  
>
>>>if(isset($emConf['constraints']) && isset($emConf['dependencies'])) {
>>>      
>>>
>>E.g. take sr_feuser_register 2.5.0 from TER.
>>
>>	'dependencies' => '',
>>
>>	'constraints' => array(
>>    
>>
> ...
>  
>
>>This code would not get reached as soon as dependencies is empty
>>    
>>
>
>empty() !== isset()
>  
>
oh.

>But you have a point here, the check would fail for new-style ext_emconf.php 
>files that only have constraints but dependencies. I moved the check out of 
>that condition.
>
>  
>
+1 tested successfully with newloginbox


- Franz






More information about the TYPO3-team-core mailing list