[TYPO3-core] RFC: Fix bug when comparing version numbers

Karsten Dambekalns karsten at typo3.org
Thu Jul 13 17:22:17 CEST 2006


On Wednesday 12 July 2006 20:41, Franz Holzinger wrote:
> I think this will not work in all cases.
> >if(isset($emConf['constraints']) && isset($emConf['dependencies'])) {
> E.g. take sr_feuser_register 2.5.0 from TER.
> 	'dependencies' => '',
> 	'constraints' => array(
> This code would not get reached as soon as dependencies is empty

empty() !== isset()

But you have a point here, the check would fail for new-style ext_emconf.php 
files that only have constraints but dependencies. I moved the check out of 
that condition.

New patch attached.

Karsten Dambekalns
TYPO3 Association - Active Member
-------------- next part --------------
A non-text attachment was scrubbed...
Name: versioncompare.diff
Type: text/x-diff
Size: 1467 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20060713/90d947e7/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 307 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20060713/90d947e7/attachment.pgp 

More information about the TYPO3-team-core mailing list