[TYPO3-core] RFC: drag&drop to copy/move pages
Sebastian Kurfuerst
sebastian at garbage-group.de
Sat Jan 28 17:56:57 CET 2006
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Franz,
> I prefer the usage of a local variable for this, because this is more
> understandable than the strcmp function.
>
> $dragDrop = t3lib_div::_GP('dragDrop');
> if ($dragDrop) {
> $this->iParts[0] = $dragDrop;
> ...
> }
I think that's ok, and IMHO Robert once suggested the use of strcmp
for strings.
>> return $CMcontent;
> -1 for that
The "early" return is just fine. I checked it how it works, and that
is exactly the way it needs to be. If there is a "drag and drop"
action, it outputs the correct code and exits.
If not, the code executes the way it was before, which is the correct way.
Btw @michael - an "exit" (or something like that) should be added
after the "return" - I think somebody from this list said that some
time ago. (Robert too if my mind is right).
Greets, Sebastian
PS: I forgot - when all things are done I mentioned +1
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFD26JWygDVWNTabbkRAr+5AJ98Z4pYPL6pdh7DUMbXg6A0bVJDvwCfQ3O5
cEV1tPW2SO4ZqGszZfAsqFU=
=8t9y
-----END PGP SIGNATURE-----
More information about the TYPO3-team-core
mailing list