[TYPO3-core] RFC: fix feature request #568

[Michael Stucki]

Hi Wolfgang,

did you notice Kaspers reply in message
mailman.7561.1138115707.6406.typo3-team-core at lists.netfielders.de?

Quote:
> I think the match-condition patch can be applied with the regular  
> four-eye review. But I remember rejecting it - even reverting it from   
> CVS! - because it introduced new problems! So try it, but promise to   
> respond to any problems it may cause. 

Regards, michael

>  *hiya!*
> 
>  On Thu, 19 Jan 2006, Bernhard Kraft wrote the following:
>> Please send again such a easier to read patch and I will look on it, test
>> this one (send a new one with indendting respected if you changed
>> something in between) and send you my opinion.
>  
>  done, attached, sorry didn't know that
> 
>> Fine with that if also (string)"0" should return true for that (is not
>> everywhere the case in T3. i.e. if you check a TS value it might have
>> also been set to (string)"0" which means "false". i.e:
>> "stdWrap.insertData = 0" )
> 
>  not the case here IMHO,
>  and I know that 0 is treated as false :-)
> 
>> You have 't3lib/class.t3lib_matchcondition.php' definig the file in which
>> the hook is found and "devices_class" as the name of the hook.
>> in t3lib_tcemain.php you have "t3lib/class.t3lib_tcemain.php" as file
>> name and "preProcessDatamapClass" as hook name for example.
> 
>  I want one "hook class" for this, not three for every method,
>  I think that's cleaner?
> 
>> If I understand you correct you would like to have only ONE
>> ['matchConditionClass'] array for the whole class ?? Or am I
>> misunderstanding something ?
> 
>  right, something wrong with that (I don't know)?
> 
>> If you provide a backwards compatible version I would be fine with it.
>> And let's remove the backwards compatibility let's say in 4.2.0 or so
> 
>  ok
> 
>> The hookObjectsArr in the mentioned example are always local variables !
> 
>  but I'll use it in more than one place in this class...
> 
>> Stay with the coding guidelines and simply do a "return" or "break" after
>> the first valid hook-object (or the first one which returned a valid
>> value).
> 
>  ..and that's the question: valid object or valid value? Is that
>  something that's handled for each hook seperately? I would (in this
>  case) choose to return only if the return value contains something
>  (strlen check).
> 
>> Using only a simple variable instead of an array would bring up other
>> questions why the standard is not kept in this place.
> 
>  true though...
> 
> 
>  bye
>  Wolfgang

-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/