[TYPO3-core] CVS Patch request. Dmail boundaries

Michael Stucki michael at typo3.org
Wed Jan 25 15:17:01 CET 2006


Hi Jan-Erik,

perfect! +1

Michael

Am Mittwoch, 25. Januar 2006 15:11 schrieb Jan-Erik Revsbech (MOC):
> > Michael Stucki wrote:
> >
> > Hi Jan-Erik,
> >
> >
> > Makes sense, but please give more care on the coding style.
> >
> > - add an empty line before and after each function
> > - the phpdoc header of getTTcontentDmailCategories() misses a
> > return key, plus
> >   the 2nd parameter is "param instead of @param.
> > - the parameters of the phpdoc header must contain tabs
> > - add a blank after control structures like if, while, etc.
> > - add a tab before the "{" on such lines (except for "class"
> > and "else")
> > - lines 1317 and 1318 are indented wrong
>
> OK thanks, I have corrected this and attached is a new patch.
>
> > Finally I think that the comment line about direct_mail 2.0
> > is not needed.
>
> OK, I removed it.
>
> > Sorry for being so accurate but we should try to keep the
> > level as high as possible.
>
> Agreed, I was just to sloopy. I'll pull myself together and try to code
> according to the guidelines.
>
> > Regards, michael
> >
> > PS: After all these changes related to direct_mail it is
> > important that the next version depends on version 4.0 and vice versa.
>
> Direct mail will be dependant on TYPO3 4.0
>
> Regards
> /Jan-Erik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20060125/0388b899/attachment.pgp 


More information about the TYPO3-team-core mailing list