[TYPO3-core] RFC: Bug 1030, 277, 1472 possibly 1270

[Bernhard Kraft]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Kasper Skårhøj wrote:

> If there is a better way today lets implement that and make sure it is used 
> EVERYWHERE JS labels are used so it works for every charset (also non-UTF8 of 
> course!). I'm OK with the change if you are committed to fix any problems it 
> might have. And you can author some thing for the coding guidelines .

I mis-posted this just to kasper. So here for all of you.

Commited to CVS.

I tested it with Chinese Traditional and Simplified (cause I had one bug report for
an earlier patch without chr(10).chr(13) as stated in the notes of bug 277 from Stanislas)
and with Japanese. And a lot with utf-8 and characters from different languages.

I didn't search for all uses os JScharCode but rather fixed all bugs reported to me about
this problem (these are the 3 official which are related from 277) and one "unoffical" from
Michael.

I will look out for problems with character sets in beta2 in the newsgroups (hope we have
a ng-mirror on t3board06 :)


The changes for the codinguidelines are following ...
Once you wrote to one of us that we shall send you a .sxw with the table parts so you can
just copy and paste the row over ... but some time earlier
you seemed to prefer - or was it Michael who suggested this format - a plain text listing.

I prefer the previous form as it is easier to view in mails :)


doc_core_cgl
http://typo3.org/documentation/document-library/doc_core_cgl/

1.6.2 TYPO3 specific practices

Add as extra <li>:
- ----------------
When values/labels from the database get inserted into HTML tag attribute values or  JavaScripts
then they have to get quoted properly. This can be done using "t3lib_div::quoteJSvalue($value, $inScriptTags)".
Set the second parameter to true when the value get's used in <script> tags and to false if it get's used
in an attribute of a tag (onClick i.e)
- ---------------------

Somebody should proofread it before inserted into the document ...


greets,
Bernhard
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDzicfIl4dkVkDMFkRAv9QAJ0emzBO06etjHuTrzbrTRnvEIrEkACgkbyg
zQnY5n/iuJV8ZS3hzUAZPJw=
=J4fV
-----END PGP SIGNATURE-----