[TYPO3-core] RFC: #2119: Clean-up in mailform code: more TypoScript flexibility

[Michael Stucki]

Hi Sebastian,

as promised, here are my comments:

I don't like to have redundant TS keys:

  $confData['typeUpper'] = strtoupper($confData['type']);

After all, Typoscript properties have always been case sensitive. Even if
you still want to introduce case-insensitivity (could be confusing for some
people - why here, not there?) it would be much easier to use this one
instead:

  $confData['type'] = strtolower($confData['type']);


The next thing that bugs me is that $conf['accessibility'] seems to be
completely ignored. You write that this is now controllable through
Typoscript, but either a false or a true $conf['accessibility'] will
require manual changes therefore.

This needs to be changed - for some reason $conf['accessibility'] is
configurable and not selected by default.

Why don't you keep the accessibility flag but set it automatically depending
on COMPAT_VERSION?


Last thing: In the TS setup.txt, I prefer to have these statements shortened
on one line:

Instead of:

-  PASSWORD {
-    addParams = id="###ID###" class="csc-mailform-password"
-  }
-  FILE {
-    addParams = id="###ID###" class="csc-mailform-file"
-  }
-  TEXTAREA {
-    addParams = id="###ID###" class="csc-mailform-textarea"
-  }
-  SELECT {
-    addParams = id="###ID###" class="csc-mailform-select"
-  }

Write this:

+  PASSWORD.addParams = id="###ID###" class="csc-mailform-password"
+  FILE.addParams = id="###ID###" class="csc-mailform-file"
+  TEXTAREA.addParams = id="###ID###" class="csc-mailform-textarea"
+  SELECT.addParams = id="###ID###" class="csc-mailform-select"

(You can still align the "=" if you prefer that!)


After all I didn't check if and how the patch works after - I first like to
discuss the above comments.

Regards, michael
-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/