[TYPO3-core] RFC: fix for bug #2592

Franz Holzinger franz at fholzinger.com
Mon Feb 20 13:09:06 CET 2006


Hello Wolfgang,

> 
> *hiya!*
> 
> Type: bugfix
>
> Page type "External URL" causes an error (PHP header warning)
> BT reference: http://bugs.typo3.org/view.php?id=2592
> 
> This bug is caused by changes of "stanrolland" on Feb 10 17:09:34,
> so please Stanislas take an indepth look at it.
> (http://cvs.sourceforge.net/viewcvs.py/typo3/TYPO3core/typo3/sysext/cms/tslib/class.tslib_fe.php?r1=1.104.2.8&r2=1.104.2.9)
>
>  
>

> 	function checkJumpUrl()	{
>+		if ($extUrl = $this->sys_page->getExtURL($this->page, $this->config['config']['disablePageExternalUrl']))	{
>+			$this->jumpurl = $extUrl;
>+		}
>
When I read the name of the function 'checkJumpUrl' I think this
function should only do a check.

With your line this is also changing a local variable which it should
check only.

So please make this change somewhere else or rename the function.


- Franz





More information about the TYPO3-team-core mailing list