[TYPO3-core] Bugfix #760 GIFBUILDER 256 colors

Michael Stucki michael at typo3.org
Wed Feb 8 01:14:46 CET 2006


Hi Bernhard,

>> Rico Moorman and I tested the following patch for some time now and we
>> came to the conclusion that it works better.
> 
> The FOLLOWING patch ...
> 
> sorry but worked for 7 hours now on this to track down the issues.

I'm fine with most of it, except:

1. I dislike to introduce two more options to $TYPO3_CONF_VARS[GFX].
   Suggestions instead:
    - Use "gif" internally unless $TYPO3_CONF_VARS[GFX][gdlib_png] is set.
      I don't think that there is a need to use jpg or wbmp here.
    - Do you really think it needs to be configurable whether dithering is
      used or not? IMHO you should always turn it off.

2. operatiosn => operations

3. Always use "@" in front of "unlink" calls. Just in case...

When this is fixed, I'd vote +1 for it.

Regards, michael
-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/



More information about the TYPO3-team-core mailing list